From: Stefano Brivio <sbrivio@redhat.com>
To: Raju Rangoju <rajur@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
nirranjan@chelsio.com, indranil@chelsio.com,
venkatesh@chelsio.com, swise@opengridcomputing.com,
bharat@chelsio.com, Ganesh Goudar <ganeshgr@chelsio.com>
Subject: Re: [PATCH net-next 2/5] cxgb4: Add support to initialise/read SRQ entries
Date: Sun, 18 Mar 2018 23:37:05 +0100 [thread overview]
Message-ID: <20180318233705.2072e6b4@epycfail> (raw)
In-Reply-To: <20180317072229.21211-3-rajur@chelsio.com>
On Sat, 17 Mar 2018 12:52:26 +0530
Raju Rangoju <rajur@chelsio.com> wrote:
> +struct srq_data *t4_init_srq(int srq_size)
> +{
> + struct srq_data *s;
> +
> + s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN);
> + if (!s)
> + s = vzalloc(sizeof(*s));
> + if (!s)
> + return NULL;
I guess you could use kvzalloc() here.
> [...]
>
> +++ b/drivers/net/ethernet/chelsio/cxgb4/srq.h
>
> [...]
>
> +enum {
> + SRQ_WAIT_TO = (HZ * 5),
> +};
Why not #define? Am I missing something?
--
Stefano
next prev parent reply other threads:[~2018-03-18 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 7:22 [PATCH net-next 0/5] Add support for RDMA enhancements in cxgb4 Raju Rangoju
2018-03-17 7:22 ` [PATCH net-next 1/5] cxgb4: Adds CPL support for Shared Receive Queues Raju Rangoju
2018-03-17 7:22 ` [PATCH net-next 2/5] cxgb4: Add support to initialise/read SRQ entries Raju Rangoju
2018-03-18 22:37 ` Stefano Brivio [this message]
2018-03-17 7:22 ` [PATCH net-next 3/5] cxgb4: Add support to query HW SRQ parameters Raju Rangoju
2018-03-17 7:22 ` [PATCH net-next 4/5] cxgb4: Support firmware rdma write with immediate work request Raju Rangoju
2018-03-17 7:22 ` [PATCH net-next 5/5] cxgb4: Support firmware rdma write completion " Raju Rangoju
2018-03-18 0:19 ` [PATCH net-next 0/5] Add support for RDMA enhancements in cxgb4 David Miller
2018-03-19 9:51 ` Raju Rangoju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318233705.2072e6b4@epycfail \
--to=sbrivio@redhat.com \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rajur@chelsio.com \
--cc=swise@opengridcomputing.com \
--cc=venkatesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox