From: David Miller <davem@davemloft.net>
To: mislam4@kent.edu
Cc: ebiederm@xmission.com, xemul@openvz.org, netdev@vger.kernel.org,
shemminger@osdl.org, edumazet@google.com, dsahern@gmail.com,
roopa@cumulusnetworks.com, tom@herbertland.com,
alexei.starovoitov@gmail.com, f.fainelli@gmail.com,
brouer@redhat.com
Subject: Re: [PATCH net-next] XDP router for veth
Date: Mon, 26 Mar 2018 10:21:10 -0400 (EDT) [thread overview]
Message-ID: <20180326.102110.1068883293248258544.davem@davemloft.net> (raw)
In-Reply-To: <CAFgPn1DJ-8DDkydvvBeYtrZeNs3fMA+PuaUJNbPu9vhPUporBg@mail.gmail.com>
From: "Md. Islam" <mislam4@kent.edu>
Date: Fri, 23 Mar 2018 02:43:16 -0400
> +#ifdef CONFIG_XDP_ROUTER
> + //if IP forwarding is enabled on the receiver, create xdp_buff
> + //from skb and call xdp_router_forward()
Never use C++ comments, only use C style.
> + if(is_forwarding_enabled(rcv)){
There must be a space between 'if' and the openning parenthesis. You need
to also have a space before the openning curly braces.
In fact this entire patch is full of coding style issues, please run your
changes through checkpatch.pl before resubmitting.
next prev parent reply other threads:[~2018-03-26 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 6:43 [PATCH net-next] XDP router for veth Md. Islam
2018-03-26 14:21 ` David Miller [this message]
2018-03-27 1:01 ` Md. Islam
2018-03-27 1:03 ` Md. Islam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326.102110.1068883293248258544.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=brouer@redhat.com \
--cc=dsahern@gmail.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=mislam4@kent.edu \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shemminger@osdl.org \
--cc=tom@herbertland.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox