From: Dave Watson <davejwatson@fb.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Boris Pismenny <borisp@mellanox.com>,
Ilya Lesokhin <ilyal@mellanox.com>,
Aviad Yehezkel <aviadye@mellanox.com>
Subject: Re: [PATCH V4 net-next 06/14] net/tls: Add generic NIC offload infrastructure
Date: Tue, 27 Mar 2018 15:26:48 -0700 [thread overview]
Message-ID: <20180327222648.GA58978@davejwatson-mba.local> (raw)
In-Reply-To: <20180327215201.18859-7-saeedm@mellanox.com>
Thanks for doing the merge, it looks good to me. One issue below,
otherwise all my SW tests still pass.
On 03/27/18 02:51 PM, Saeed Mahameed wrote:
> - if (ctx->conf == TLS_SW_TX ||
> - ctx->conf == TLS_SW_RX ||
> - ctx->conf == TLS_SW_RXTX) {
> - tls_sw_free_resources(sk);
> + if (ctx->rx_conf == TLS_SW) {
> + kfree(ctx->rx.rec_seq);
> + kfree(ctx->rx.iv);
> + tls_sw_free_resources_rx(sk);
> }
>
> + if (ctx->tx_conf != TLS_HW)
> + kfree(ctx);
Looks like this needs to be hidden behind CONFIG_TLS_DEVICE, otherwise
it doesn't compile if false because TLS_HW is not defined
next prev parent reply other threads:[~2018-03-27 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 21:51 [PATCH V4 net-next 00/14] TLS offload, netdev & MLX5 support Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 01/14] tcp: Add clean acked data hook Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 02/14] net: Rename and export copy_skb_header Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 04/14] net: Add TLS offload netdev ops Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 05/14] net: Add TLS TX offload features Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 06/14] net/tls: Add generic NIC offload infrastructure Saeed Mahameed
2018-03-27 22:26 ` Dave Watson [this message]
2018-03-27 23:02 ` Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 07/14] net/tls: Support TLS device offload with IPv6 Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 08/14] net/mlx5e: Move defines out of ipsec code Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 09/14] net/mlx5: Accel, Add TLS tx offload interface Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 10/14] net/mlx5e: TLS, Add Innova TLS TX support Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 11/14] net/mlx5e: TLS, Add Innova TLS TX offload data path Saeed Mahameed
2018-03-27 21:51 ` [PATCH V4 net-next 12/14] net/mlx5e: TLS, Add error statistics Saeed Mahameed
2018-03-27 21:52 ` [PATCH V4 net-next 13/14] MAINTAINERS: Update mlx5 innova driver maintainers Saeed Mahameed
2018-03-27 21:52 ` [PATCH V4 net-next 14/14] MAINTAINERS: Update TLS maintainers Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327222648.GA58978@davejwatson-mba.local \
--to=davejwatson@fb.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=ilyal@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox