From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Ariel.Elior@cavium.com>,
<yuvalm@mellanox.com>
Subject: [PATCH net-next v2 2/5] qed: Fix PTT entry leak in the selftest error flow.
Date: Wed, 28 Mar 2018 01:43:28 -0700 [thread overview]
Message-ID: <20180328084331.2435-3-sudarsana.kalluru@cavium.com> (raw)
In-Reply-To: <20180328084331.2435-1-sudarsana.kalluru@cavium.com>
Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: Ariel Elior <ariel.elior@cavium.com>
---
drivers/net/ethernet/qlogic/qed/qed_selftest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_selftest.c b/drivers/net/ethernet/qlogic/qed/qed_selftest.c
index b88082f..cf1d447 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_selftest.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_selftest.c
@@ -128,7 +128,8 @@ int qed_selftest_nvram(struct qed_dev *cdev)
rc = qed_mcp_bist_nvm_get_num_images(p_hwfn, p_ptt, &num_images);
if (rc || !num_images) {
DP_ERR(p_hwfn, "Failed getting number of images\n");
- return -EINVAL;
+ rc = -EINVAL;
+ goto err0;
}
/* Iterate over images and validate CRC */
--
1.8.3.1
next prev parent reply other threads:[~2018-03-28 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 8:43 [PATCH net-next v2 0/5] qed*: Flash upgrade support Sudarsana Reddy Kalluru
2018-03-28 8:43 ` [PATCH net-next v2 1/5] qed: Populate nvm image attribute shadow Sudarsana Reddy Kalluru
2018-03-28 8:43 ` Sudarsana Reddy Kalluru [this message]
2018-03-28 8:43 ` [PATCH net-next v2 3/5] qed: Add APIs for flash access Sudarsana Reddy Kalluru
2018-03-28 8:43 ` [PATCH net-next v2 4/5] qed: Adapter flash update support Sudarsana Reddy Kalluru
2018-03-28 8:43 ` [PATCH net-next v2 5/5] qede: Ethtool " Sudarsana Reddy Kalluru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328084331.2435-3-sudarsana.kalluru@cavium.com \
--to=sudarsana.kalluru@cavium.com \
--cc=Ariel.Elior@cavium.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox