From: David Miller <davem@davemloft.net>
To: jallen@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, tlfalcon@linux.vnet.ibm.com,
nfont@linux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Disable irqs before exiting reset from closed state
Date: Sun, 01 Apr 2018 20:56:33 -0400 (EDT) [thread overview]
Message-ID: <20180401.205633.1756840906265553956.davem@davemloft.net> (raw)
In-Reply-To: <4511c12c-0a2a-8d46-531d-2bdc1293ca00@linux.vnet.ibm.com>
From: John Allen <jallen@linux.vnet.ibm.com>
Date: Fri, 30 Mar 2018 13:44:21 -0500
> When the driver is closed, all the associated irqs are disabled. In the
> event that the driver exits a reset in the closed state, we should be
> consistent with the state we are in directly after a close. So before we
> exit the reset routine, all irqs should be disabled as well. This will
> prevent the irqs from being enabled twice in this case and reporting a
> number of noisy warning traces.
>
> Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Applied.
prev parent reply other threads:[~2018-04-02 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 18:44 [PATCH net] ibmvnic: Disable irqs before exiting reset from closed state John Allen
2018-04-02 0:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401.205633.1756840906265553956.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox