From: David Miller <davem@davemloft.net>
To: talgi@mellanox.com
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com,
f.fainelli@gmail.com
Subject: Re: [PATCH net-next V2 4/4] net/mlx5e: Enable adaptive-TX moderation
Date: Mon, 02 Apr 2018 10:26:36 -0400 (EDT) [thread overview]
Message-ID: <20180402.102636.256697366703977259.davem@davemloft.net> (raw)
In-Reply-To: <1522677574-7506-5-git-send-email-talgi@mellanox.com>
From: Tal Gilboa <talgi@mellanox.com>
Date: Mon, 2 Apr 2018 16:59:34 +0300
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c b/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> index 1b286e1..9cec351 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> @@ -33,16 +33,30 @@
> #include <linux/net_dim.h>
> #include "en.h"
>
> +static inline void
> +mlx5e_complete_dim_work(struct net_dim *dim, struct net_dim_cq_moder moder,
> + struct mlx5_core_dev *mdev, struct mlx5_core_cq *mcq)
Do not use inline in foo.c files, let the compiler decide.
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> index f292bb3..ff1d5fe 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> @@ -44,6 +44,30 @@ static inline bool mlx5e_channel_no_affinity_change(struct mlx5e_channel *c)
> return cpumask_test_cpu(current_cpu, aff);
> }
>
> +static inline void mlx5e_handle_tx_dim(struct mlx5e_txqsq *sq)
> +{
> + struct net_dim_sample dim_sample;
Likewise.
> +static inline void mlx5e_handle_rx_dim(struct mlx5e_rq *rq)
> +{
Likewise.
next prev parent reply other threads:[~2018-04-02 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 13:59 [PATCH net-next V2 0/4] Introduce adaptive TX interrupt moderation to net DIM Tal Gilboa
2018-04-02 13:59 ` [PATCH net-next V2 1/4] net/dim: Rename *_get_profile() functions to *_get_rx_moderation() Tal Gilboa
2018-04-02 13:59 ` [PATCH net-next V2 2/4] net/dim: Add "enabled" field to net_dim struct Tal Gilboa
2018-04-02 13:59 ` [PATCH net-next V2 3/4] net/dim: Support adaptive TX moderation Tal Gilboa
2018-04-02 13:59 ` [PATCH net-next V2 4/4] net/mlx5e: Enable adaptive-TX moderation Tal Gilboa
2018-04-02 14:26 ` David Miller [this message]
2018-04-02 14:27 ` [PATCH net-next V2 0/4] Introduce adaptive TX interrupt moderation to net DIM David Miller
2018-04-02 14:42 ` Tal Gilboa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402.102636.256697366703977259.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=talgi@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox