From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Simon Horman" <simon.horman@netronome.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Dirk van der Merwe" <dirk.vandermerwe@netronome.com>,
"Pablo Cascón" <pablo.cascon@netronome.com>,
oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: nfp: fix nfp_net_tx()'s return type
Date: Tue, 24 Apr 2018 11:09:21 -0700 [thread overview]
Message-ID: <20180424110921.24c3699b@cakuba.netronome.com> (raw)
In-Reply-To: <20180424131710.4206-1-luc.vanoostenryck@gmail.com>
On Tue, 24 Apr 2018 15:17:07 +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
prev parent reply other threads:[~2018-04-24 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:17 [PATCH] net: nfp: fix nfp_net_tx()'s return type Luc Van Oostenryck
2018-04-24 18:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424110921.24c3699b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pablo.cascon@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox