From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: ast@fb.com, daniel@iogearbox.net, netdev@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next v2] samples/bpf: fix kprobe attachment issue on x64
Date: Sun, 29 Apr 2018 20:39:27 -0700 [thread overview]
Message-ID: <20180430033925.ifghcefbbzhez3wm@ast-mbp> (raw)
In-Reply-To: <20180430022748.4093322-1-yhs@fb.com>
On Sun, Apr 29, 2018 at 07:27:48PM -0700, Yonghong Song wrote:
> Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename
> struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot
> of syscall function sys_*() to __x64_sys_*().
> This caused several kprobe based samples/bpf tests failing.
>
> This patch fixed the problem in bpf_load.c.
> For x86_64 architecture, function name __x64_sys_*() will be
> first used for kprobe event creation. If the creation is successful,
> it will be used. Otherwise, function name sys_*() will be used
> for kprobe event creation.
>
> Fixes: d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()")
> Signed-off-by: Yonghong Song <yhs@fb.com>
Applied, Thanks Yonghong.
prev parent reply other threads:[~2018-04-30 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 2:27 [PATCH bpf-next v2] samples/bpf: fix kprobe attachment issue on x64 Yonghong Song
2018-04-30 3:39 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430033925.ifghcefbbzhez3wm@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox