From: Stephen Hemminger <stephen@networkplumber.org>
To: Ido Schimmel <idosch@mellanox.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, mlxsw@mellanox.com
Subject: Re: [PATCH iproute2-master] iproute: Parse last nexthop in a multipath route
Date: Tue, 1 May 2018 19:37:05 -0700 [thread overview]
Message-ID: <20180501193705.6044a561@xeon-e3> (raw)
In-Reply-To: <20180501131635.14981-1-idosch@mellanox.com>
On Tue, 1 May 2018 16:16:35 +0300
Ido Schimmel <idosch@mellanox.com> wrote:
> Continue parsing a multipath payload as long as another nexthop can fit
> in the payload.
>
> # ip route add 192.0.2.0/24 nexthop dev dummy0 nexthop dev dummy1
>
> Before:
> # ip route show 192.0.2.0/24
> 192.0.2.0/24
> nexthop dev dummy0 weight 1
>
> After:
> # ip route show 192.0.2.0/24
> 192.0.2.0/24
> nexthop dev dummy0 weight 1
> nexthop dev dummy1 weight 1
>
> Fixes: f48e14880a0e ("iproute: refactor multipath print")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Applied, thanks.
There really ought to be test cases for this.
prev parent reply other threads:[~2018-05-02 2:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 13:16 [PATCH iproute2-master] iproute: Parse last nexthop in a multipath route Ido Schimmel
2018-05-01 14:59 ` David Ahern
2018-05-02 2:37 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501193705.6044a561@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox