From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Arkadi Sharshevsky <arkadis@mellanox.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support
Date: Thu, 3 May 2018 15:15:15 +0200 [thread overview]
Message-ID: <20180503131515.GB17027@lunn.ch> (raw)
In-Reply-To: <20180503130648.23225-1-marek.behun@nic.cz>
On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote:
> The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane,
> which can be configured the same way as the SERDES lane on 88E6390.
>
> Signed-off-by: Marek Behun <marek.behun@nic.cz>
> +int mv88e6341_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
> +{
> + int err;
> + u8 cmode;
> +
> + if (port != 5)
> + return 0;
> +
> + err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
> + if (err)
> + return err;
> +
> + if ((cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
> + (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII) ||
> + (cmode == MV88E6XXX_PORT_STS_CMODE_2500BASEX))
> + return mv88e6390_serdes_sgmii(chip, 0x15, on);
Hi Marek
Please add a #define for this 0x15.
Otherwise, this looks good.
Andrew
next prev parent reply other threads:[~2018-05-03 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 13:06 [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support Marek Behún
2018-05-03 13:15 ` Andrew Lunn [this message]
2018-05-03 14:31 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503131515.GB17027@lunn.ch \
--to=andrew@lunn.ch \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox