From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com,
weilin.chang@cavium.com
Subject: Re: [PATCH net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards
Date: Fri, 04 May 2018 13:00:22 -0400 (EDT) [thread overview]
Message-ID: <20180504.130022.456100476632220937.davem@davemloft.net> (raw)
In-Reply-To: <20180504022325.GA1332@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Thu, 3 May 2018 19:23:25 -0700
> +static int lio_set_link_ksettings(struct net_device *netdev,
> + const struct ethtool_link_ksettings *ecmd)
> +{
> + struct lio *lio = GET_LIO(netdev);
> + struct octeon_device *oct = lio->oct_dev;
> + struct oct_link_info *linfo;
> + const int speed = ecmd->base.speed;
> + u32 is25G = 0;
Please order local variable declarations from longest to shortest line,
as was properly done in the rest of this patch.
Thank you.
prev parent reply other threads:[~2018-05-04 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 2:23 [PATCH net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards Felix Manlunas
2018-05-04 17:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504.130022.456100476632220937.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
--cc=weilin.chang@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox