From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
tglx@linutronix.de,
Anna-Maria Gleixner <anna-maria@linutronix.de>
Subject: Re: [PATCH 2/4] net: 3com: 3c59x: Move boomerang/vortex conditional into function
Date: Fri, 4 May 2018 17:22:28 +0200 [thread overview]
Message-ID: <20180504152228.o24gdwcf2oft52u4@linutronix.de> (raw)
In-Reply-To: <20180504151749.6966-3-bigeasy@linutronix.de>
On 2018-05-04 17:17:47 [+0200], To netdev@vger.kernel.org wrote:
> From: Anna-Maria Gleixner <anna-maria@linutronix.de>
>
> If vp->full_bus_master_tx is set, vp->full_bus_master_rx is set as well
> (see vortex_probe1()). Therefore the conditionals for the decision if
> boomerang or vortex ISR is executed have the same result. Instead of
> repeating the explicit conditional execution of the boomerang/vortex ISR,
> move it into an own function.
>
> No functional change.
>
> Cc: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Steffen, this email address is still listed in the MAINTAINERS file for
the driver and rejects emails.
Sebastian
next prev parent reply other threads:[~2018-05-04 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 15:17 3c59x patches and the removal of an unused function Sebastian Andrzej Siewior
2018-05-04 15:17 ` [PATCH 1/4] net: u64_stats_sync: Remove functions without user Sebastian Andrzej Siewior
2018-05-04 15:17 ` [PATCH 2/4] net: 3com: 3c59x: Move boomerang/vortex conditional into function Sebastian Andrzej Siewior
2018-05-04 15:22 ` Sebastian Andrzej Siewior [this message]
2018-05-07 10:25 ` Steffen Klassert
2018-05-04 15:17 ` [PATCH 3/4] net: 3com: 3c59x: Pull locking out of ISR Sebastian Andrzej Siewior
2018-05-04 15:17 ` [PATCH 4/4] net: 3com: 3c59x: irq save variant " Sebastian Andrzej Siewior
2018-05-08 3:26 ` 3c59x patches and the removal of an unused function David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504152228.o24gdwcf2oft52u4@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox