From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Mathieu Xhonneux <m.xhonneux@gmail.com>
Cc: netdev@vger.kernel.org, ys114321@gmail.com, daniel@iogearbox.net
Subject: Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local
Date: Fri, 25 May 2018 09:23:14 -0700 [thread overview]
Message-ID: <20180525162312.dadn2wtcp4bkf2la@ast-mbp> (raw)
In-Reply-To: <20180525112036.4768-1-m.xhonneux@gmail.com>
On Fri, May 25, 2018 at 12:20:36PM +0100, Mathieu Xhonneux wrote:
> Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks
> some UAPI headers in tools/.
>
> clang -I. -I./include/uapi -I../../../include/uapi -idirafter
> /usr/local/include -idirafter
> /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include
> -idirafter /usr/include -Wno-compare-distinct-pointer-types \
> -O2 -target bpf -emit-llvm -c test_lwt_seg6local.c -o - | \
> llc -march=bpf -mcpu=generic -filetype=obj -o
> [...]/net-next/tools/testing/selftests/bpf/test_lwt_seg6local.o
> test_lwt_seg6local.c:4:10: fatal error: 'linux/seg6_local.h' file not found
> ^~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> make: Leaving directory
> `/data/users/yhs/work/net-next/tools/testing/selftests/bpf'
>
> Reported-by: Y Song <ys114321@gmail.com>
> Signed-off-by: Mathieu Xhonneux <m.xhonneux@gmail.com>
> ---
> .../selftests/bpf/include/uapi/linux/seg6.h | 55 +++++++++++++++
> .../selftests/bpf/include/uapi/linux/seg6_local.h | 80 ++++++++++++++++++++++
> 2 files changed, 135 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/include/uapi/linux/seg6.h
> create mode 100644 tools/testing/selftests/bpf/include/uapi/linux/seg6_local.h
>
> diff --git a/tools/testing/selftests/bpf/include/uapi/linux/seg6.h b/tools/testing/selftests/bpf/include/uapi/linux/seg6.h
hmm. why to selftest?
Shouldn't they be added to tools/include/uapi/linux/ instead?
next prev parent reply other threads:[~2018-05-25 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 11:20 [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local Mathieu Xhonneux
2018-05-25 16:16 ` Y Song
2018-05-25 16:22 ` Y Song
2018-05-25 16:20 ` Song Liu
2018-05-25 16:23 ` Alexei Starovoitov [this message]
2018-05-25 16:39 ` Daniel Borkmann
2018-05-26 12:26 ` Mathieu Xhonneux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525162312.dadn2wtcp4bkf2la@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=m.xhonneux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ys114321@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox