* [PATCH] ieee802154: mcr20a: add missing includes
@ 2018-05-30 21:47 Arnd Bergmann
2018-06-01 21:52 ` Xue Liu
2018-07-05 9:57 ` Stefan Schmidt
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-05-30 21:47 UTC (permalink / raw)
To: Xue Liu, Alexander Aring, Stefan Schmidt, David S. Miller
Cc: Arnd Bergmann, Colin Ian King, Gustavo A. R. Silva, linux-wpan,
netdev, linux-kernel
Without CONFIG_GPIOLIB, some headers are not included implicitly,
leading to a build failure:
drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe':
drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration]
This includes gpio/consumer.h and irq.h directly rather through the
gpiolib header.
Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ieee802154/mcr20a.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index de0d7f28a181..e428277781ac 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -15,10 +15,11 @@
*/
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/spi/spi.h>
#include <linux/workqueue.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/skbuff.h>
#include <linux/of_gpio.h>
#include <linux/regmap.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ieee802154: mcr20a: add missing includes
2018-05-30 21:47 [PATCH] ieee802154: mcr20a: add missing includes Arnd Bergmann
@ 2018-06-01 21:52 ` Xue Liu
2018-07-05 9:57 ` Stefan Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: Xue Liu @ 2018-06-01 21:52 UTC (permalink / raw)
To: arnd
Cc: alex. aring, Stefan Schmidt, David S. Miller, colin.king,
Gustavo A. R. Silva, linux-wpan - ML, netdev, linux-kernel
Hello Arnd,
Thanks for the fix.
Acked-by: Xue Liu <liuxuenetmail@gmail.com>
On Wed, 30 May 2018 at 23:47, Arnd Bergmann <arnd@arndb.de> wrote:
>
> Without CONFIG_GPIOLIB, some headers are not included implicitly,
> leading to a build failure:
>
> drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe':
> drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration]
>
> This includes gpio/consumer.h and irq.h directly rather through the
> gpiolib header.
>
> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ieee802154/mcr20a.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index de0d7f28a181..e428277781ac 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -15,10 +15,11 @@
> */
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/spi/spi.h>
> #include <linux/workqueue.h>
> #include <linux/interrupt.h>
> +#include <linux/irq.h>
> #include <linux/skbuff.h>
> #include <linux/of_gpio.h>
> #include <linux/regmap.h>
> --
> 2.9.0
>
--
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ieee802154: mcr20a: add missing includes
2018-05-30 21:47 [PATCH] ieee802154: mcr20a: add missing includes Arnd Bergmann
2018-06-01 21:52 ` Xue Liu
@ 2018-07-05 9:57 ` Stefan Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Schmidt @ 2018-07-05 9:57 UTC (permalink / raw)
To: Arnd Bergmann, Xue Liu, Alexander Aring, Stefan Schmidt,
David S. Miller
Cc: Colin Ian King, Gustavo A. R. Silva, linux-wpan, netdev,
linux-kernel
Hello.
[Sorry for the delay here, I was on a few weeks on leave]
On 30.05.2018 23:47, Arnd Bergmann wrote:
> Without CONFIG_GPIOLIB, some headers are not included implicitly,
> leading to a build failure:
>
> drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe':
> drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration]
>
> This includes gpio/consumer.h and irq.h directly rather through the
> gpiolib header.
>
> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ieee802154/mcr20a.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index de0d7f28a181..e428277781ac 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -15,10 +15,11 @@
> */
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/spi/spi.h>
> #include <linux/workqueue.h>
> #include <linux/interrupt.h>
> +#include <linux/irq.h>
> #include <linux/skbuff.h>
> #include <linux/of_gpio.h>
> #include <linux/regmap.h>
>
This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-05 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-30 21:47 [PATCH] ieee802154: mcr20a: add missing includes Arnd Bergmann
2018-06-01 21:52 ` Xue Liu
2018-07-05 9:57 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox