From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Alexey Kodanev <alexey.kodanev@oracle.com>,
netfilter-devel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
coreteam@netfilter.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] netfilter: nf_tables: check msg_type before nft_trans_set(trans)
Date: Fri, 1 Jun 2018 10:14:11 +0200 [thread overview]
Message-ID: <20180601081411.sk4py3rkduckmiyg@salvia> (raw)
In-Reply-To: <20180531190731.rrwayqgnnnd2fasn@breakpoint.cc>
On Thu, May 31, 2018 at 09:07:31PM +0200, Florian Westphal wrote:
> Alexey Kodanev <alexey.kodanev@oracle.com> wrote:
> > The patch moves the "trans->msg_type == NFT_MSG_NEWSET" check before
> > using nft_trans_set(trans). Otherwise we can get out of bounds read.
>
> Indeed, thanks for fixining this.
>
> Acked-by: Florian Westphal <fw@strlen.de>
Also applied to nf.git, thanks!
prev parent reply other threads:[~2018-06-01 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 16:53 [PATCH net-next] netfilter: nf_tables: check msg_type before nft_trans_set(trans) Alexey Kodanev
2018-05-31 19:07 ` Florian Westphal
2018-06-01 8:14 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601081411.sk4py3rkduckmiyg@salvia \
--to=pablo@netfilter.org \
--cc=alexey.kodanev@oracle.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox