Re: [PATCH 1/1] ip: add rmnet initial support

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 12 Jun 2018 16:12:57 +0200
Daniele Palmas <dnlplm@gmail.com> wrote:

> This patch adds basic support for Qualcomm rmnet devices.
> 
> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
> ---
>  ip/Makefile       |  2 +-
>  ip/iplink.c       |  2 +-
>  ip/iplink_rmnet.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 72 insertions(+), 2 deletions(-)
>  create mode 100644 ip/iplink_rmnet.c
};

I am glad to see integrated tool support, but this needs to be targeted at
the iproute2-next since it is a new feature.

Some things that I would like to see changed:
  1. All of iproute2 is now using SPDX license identifiers, you should not
     include GPL boilerplate
  2. You should provide dump (print_opt) as well as parse routine.
     Output format should use the print_uint (json print) routines.
  3. Please update manual page (man/man8/ip-link.8.in) to include the new
     option.