From: Dave Watson <davejwatson@fb.com>
To: Vakul Garg <vakul.garg@nxp.com>
Cc: <davem@davemloft.net>, <doronrk@fb.com>, <tom@quantonium.net>,
<john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
<ebiggers@google.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net][RESEND] strparser: Don't schedule in workqueue in paused state
Date: Wed, 20 Jun 2018 10:32:10 -0700 [thread overview]
Message-ID: <20180620173210.GA6064@davejwatson-mba.local> (raw)
In-Reply-To: <20180620215949.32334-1-vakul.garg@nxp.com>
On 06/21/18 03:29 AM, Vakul Garg wrote:
> In function strp_data_ready(), it is useless to call queue_work if
> the state of strparser is already paused. The state checking should
> be done before calling queue_work. The change reduces the context
> switches and improves the ktls-rx throughput by approx 20% (measured
> on cortex-a53 based platform).
Nice find, works for me. Although current code isn't broken, just
slower, net-next would be fine.
Acked-by: Dave Watson <davejwatson@fb.com>
next prev parent reply other threads:[~2018-06-20 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 21:59 [PATCH net][RESEND] strparser: Don't schedule in workqueue in paused state Vakul Garg
2018-06-20 17:32 ` Dave Watson [this message]
2018-06-21 0:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620173210.GA6064@davejwatson-mba.local \
--to=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=doronrk@fb.com \
--cc=ebiggers@google.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@quantonium.net \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox