From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Chengguang Xu <cgxu519@gmx.com>
Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net/nfp: cast sizeof() to int when comparing with error code
Date: Mon, 25 Jun 2018 11:11:24 -0700 [thread overview]
Message-ID: <20180625111124.097a69ed@cakuba.netronome.com> (raw)
In-Reply-To: <20180625073318.6828-1-cgxu519@gmx.com>
On Mon, 25 Jun 2018 15:33:18 +0800, Chengguang Xu wrote:
> Negative error code will be larger than sizeof().
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
You should include the name of the tree in the tag, e.g. [PATCH net] or
[PATCH net-next] and if it's a fix, i.e. directed at the net tree, you
should add a fixes tag, in this case it would most likely be:
Fixes: a0d8e02c35ff ("nfp: add support for reading nffw info")
You can find this and more information about the development process of
the networking subsystem in:
https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thank you!
prev parent reply other threads:[~2018-06-25 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 7:33 [PATCH] net/nfp: cast sizeof() to int when comparing with error code Chengguang Xu
2018-06-25 18:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625111124.097a69ed@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=cgxu519@gmx.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox