From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: alexei.starovoitov@gmail.com, daniel@iogearbox.net
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH bpf-next 1/8] tools: bpftool: use correct make variable type to improve compilation time
Date: Thu, 28 Jun 2018 14:41:35 -0700 [thread overview]
Message-ID: <20180628214142.11268-2-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20180628214142.11268-1-jakub.kicinski@netronome.com>
Commit 4bfe3bd3cc35 ("tools/bpftool: use version from the kernel
source tree") added version to bpftool. The version used is
equal to the kernel version and obtained by running make kernelversion
against kernel source tree. Version is then communicated
to the sources with a command line define set in CFLAGS.
Use a simply expanded variable for the version, otherwise the
recursive make will run every time CFLAGS are used.
This brings the single-job compilation time for me from almost
16 sec down to less than 4 sec.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
---
tools/bpf/bpftool/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index 892dbf095bff..0911b00b25cc 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -23,7 +23,7 @@ endif
LIBBPF = $(BPF_PATH)libbpf.a
-BPFTOOL_VERSION=$(shell make --no-print-directory -sC ../../.. kernelversion)
+BPFTOOL_VERSION := $(shell make --no-print-directory -sC ../../.. kernelversion)
$(LIBBPF): FORCE
$(Q)$(MAKE) -C $(BPF_DIR) OUTPUT=$(OUTPUT) $(OUTPUT)libbpf.a FEATURES_DUMP=$(FEATURE_DUMP_EXPORT)
--
2.17.1
next prev parent reply other threads:[~2018-06-28 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:41 [PATCH bpf-next 0/8] tools: bpf: updates to bpftool and libbpf Jakub Kicinski
2018-06-28 21:41 ` Jakub Kicinski [this message]
2018-06-28 21:41 ` [PATCH bpf-next 2/8] tools: libbpf: add section names for missing program types Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 3/8] tools: libbpf: allow setting ifindex for programs and maps Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 4/8] tools: libbpf: restore the ability to load programs from .text section Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 5/8] tools: libbpf: don't return '.text' as a program for multi-function programs Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 6/8] tools: bpftool: drop unnecessary Author comments Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 7/8] tools: bpftool: add missing --bpffs to completions Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 8/8] tools: bpftool: deal with options upfront Jakub Kicinski
2018-06-30 23:03 ` [PATCH bpf-next 0/8] tools: bpf: updates to bpftool and libbpf Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628214142.11268-2-jakub.kicinski@netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox