From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: alexei.starovoitov@gmail.com, daniel@iogearbox.net
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH bpf-next 5/8] tools: libbpf: don't return '.text' as a program for multi-function programs
Date: Thu, 28 Jun 2018 14:41:39 -0700 [thread overview]
Message-ID: <20180628214142.11268-6-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20180628214142.11268-1-jakub.kicinski@netronome.com>
Make bpf_program__next() skip over '.text' section if object file
has pseudo calls. The '.text' section is hardly a program in that
case, it's more of a storage for code of functions other than main.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
---
tools/lib/bpf/libbpf.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index e2401b95f08d..38ed3e92e393 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -1865,8 +1865,8 @@ void *bpf_object__priv(struct bpf_object *obj)
return obj ? obj->priv : ERR_PTR(-EINVAL);
}
-struct bpf_program *
-bpf_program__next(struct bpf_program *prev, struct bpf_object *obj)
+static struct bpf_program *
+__bpf_program__next(struct bpf_program *prev, struct bpf_object *obj)
{
size_t idx;
@@ -1887,6 +1887,18 @@ bpf_program__next(struct bpf_program *prev, struct bpf_object *obj)
return &obj->programs[idx];
}
+struct bpf_program *
+bpf_program__next(struct bpf_program *prev, struct bpf_object *obj)
+{
+ struct bpf_program *prog = prev;
+
+ do {
+ prog = __bpf_program__next(prog, obj);
+ } while (prog && bpf_program__is_function_storage(prog, obj));
+
+ return prog;
+}
+
int bpf_program__set_priv(struct bpf_program *prog, void *priv,
bpf_program_clear_priv_t clear_priv)
{
--
2.17.1
next prev parent reply other threads:[~2018-06-28 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:41 [PATCH bpf-next 0/8] tools: bpf: updates to bpftool and libbpf Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 1/8] tools: bpftool: use correct make variable type to improve compilation time Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 2/8] tools: libbpf: add section names for missing program types Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 3/8] tools: libbpf: allow setting ifindex for programs and maps Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 4/8] tools: libbpf: restore the ability to load programs from .text section Jakub Kicinski
2018-06-28 21:41 ` Jakub Kicinski [this message]
2018-06-28 21:41 ` [PATCH bpf-next 6/8] tools: bpftool: drop unnecessary Author comments Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 7/8] tools: bpftool: add missing --bpffs to completions Jakub Kicinski
2018-06-28 21:41 ` [PATCH bpf-next 8/8] tools: bpftool: deal with options upfront Jakub Kicinski
2018-06-30 23:03 ` [PATCH bpf-next 0/8] tools: bpf: updates to bpftool and libbpf Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628214142.11268-6-jakub.kicinski@netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox