From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: remove TBI 1000BaseX support
Date: Sat, 30 Jun 2018 20:54:43 +0900 (KST) [thread overview]
Message-ID: <20180630.205443.1624830055097480523.davem@davemloft.net> (raw)
In-Reply-To: <e68152e2-4187-ad39-39e4-dadad5a1f6cd@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 29 Jun 2018 08:07:04 +0200
> The very first version of RTL8169 from 2002 (and only this one) has
> support for a TBI 1000BaseX fiber interface. The TBI support in the
> driver makes switching to phylib tricky, so best would be to get
> rid of it. I found no report from anybody using a device with RTL8169
> and fiber interface, also the vendor driver doesn't support this mode
> (any longer).
> So remove TBI support and bail out with a message if a card with
> activated TBI is detected. If there really should be any user of it
> out there, we could add a stripped-down version of the driver
> supporting chip version 01 and TBI only (and maybe move it to
> staging).
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Ok, I guess this is reasonable.
Applied, but it will be a mini-disaster if someone is actually making
use of this fiber support for whatever reason.
prev parent reply other threads:[~2018-06-30 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 6:07 [PATCH] r8169: remove TBI 1000BaseX support Heiner Kallweit
2018-06-29 6:08 ` Heiner Kallweit
2018-06-30 11:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180630.205443.1624830055097480523.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox