* [PATCH net] qed: off by one in qed_parse_mcp_trace_buf()
@ 2018-07-04 9:52 Dan Carpenter
2018-07-04 10:45 ` Tayar, Tomer
2018-07-05 11:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-07-04 9:52 UTC (permalink / raw)
To: Ariel Elior, Michal Kalderon
Cc: everest-linux-l2, David S. Miller, netdev, kernel-janitors
If format_idx == s_mcp_trace_meta.formats_num then we read one element
beyond the end of the s_mcp_trace_meta.formats[] array.
Fixes: 50bc60cb155c ("qed*: Utilize FW 8.33.11.0")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c
index a14e48489029..4340c4c90bcb 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
@@ -6723,7 +6723,7 @@ static enum dbg_status qed_parse_mcp_trace_buf(u8 *trace_buf,
format_idx = header & MFW_TRACE_EVENTID_MASK;
/* Skip message if its index doesn't exist in the meta data */
- if (format_idx > s_mcp_trace_meta.formats_num) {
+ if (format_idx >= s_mcp_trace_meta.formats_num) {
u8 format_size =
(u8)((header & MFW_TRACE_PRM_SIZE_MASK) >>
MFW_TRACE_PRM_SIZE_SHIFT);
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH net] qed: off by one in qed_parse_mcp_trace_buf()
2018-07-04 9:52 [PATCH net] qed: off by one in qed_parse_mcp_trace_buf() Dan Carpenter
@ 2018-07-04 10:45 ` Tayar, Tomer
2018-07-05 11:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tayar, Tomer @ 2018-07-04 10:45 UTC (permalink / raw)
To: Dan Carpenter, Elior, Ariel, Kalderon, Michal
Cc: Dept-Eng Everest Linux L2, David S. Miller,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: Wednesday, July 04, 2018 12:53 PM
> If format_idx == s_mcp_trace_meta.formats_num then we read one element
> beyond the end of the s_mcp_trace_meta.formats[] array.
>
> Fixes: 50bc60cb155c ("qed*: Utilize FW 8.33.11.0")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks
Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] qed: off by one in qed_parse_mcp_trace_buf()
2018-07-04 9:52 [PATCH net] qed: off by one in qed_parse_mcp_trace_buf() Dan Carpenter
2018-07-04 10:45 ` Tayar, Tomer
@ 2018-07-05 11:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-05 11:13 UTC (permalink / raw)
To: dan.carpenter
Cc: Ariel.Elior, Michal.Kalderon, everest-linux-l2, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 4 Jul 2018 12:52:36 +0300
> If format_idx == s_mcp_trace_meta.formats_num then we read one element
> beyond the end of the s_mcp_trace_meta.formats[] array.
>
> Fixes: 50bc60cb155c ("qed*: Utilize FW 8.33.11.0")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-05 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-04 9:52 [PATCH net] qed: off by one in qed_parse_mcp_trace_buf() Dan Carpenter
2018-07-04 10:45 ` Tayar, Tomer
2018-07-05 11:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox