* [PATCH net] hv/netvsc: fix handling of fallback to single queue mode
@ 2018-07-13 17:38 Stephen Hemminger
2018-07-16 21:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2018-07-13 17:38 UTC (permalink / raw)
To: haiyangz; +Cc: netdev, Stephen Hemminger
The netvsc device may need to fallback to running in single queue
mode if host side only wants to support single queue.
Recent change for handling mtu broke this in setup logic.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 3ffe64f1a641 ("hv_netvsc: split sub-channel setup into async and sync")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/net/hyperv/rndis_filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 9b4e3c3787e5..408ece27131c 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -1338,6 +1338,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
/* setting up multiple channels failed */
net_device->max_chn = 1;
net_device->num_chn = 1;
+ return 0;
err_dev_remv:
rndis_filter_device_remove(dev, net_device);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] hv/netvsc: fix handling of fallback to single queue mode
2018-07-13 17:38 [PATCH net] hv/netvsc: fix handling of fallback to single queue mode Stephen Hemminger
@ 2018-07-16 21:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-16 21:01 UTC (permalink / raw)
To: stephen; +Cc: haiyangz, netdev, sthemmin
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 13 Jul 2018 10:38:38 -0700
> The netvsc device may need to fallback to running in single queue
> mode if host side only wants to support single queue.
>
> Recent change for handling mtu broke this in setup logic.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 3ffe64f1a641 ("hv_netvsc: split sub-channel setup into async and sync")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-16 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-13 17:38 [PATCH net] hv/netvsc: fix handling of fallback to single queue mode Stephen Hemminger
2018-07-16 21:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox