From: Richard Cochran <richardcochran@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Stefan Sørensen" <stefan.sorensen@spectralink.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: fix missing break in switch
Date: Tue, 17 Jul 2018 20:46:00 -0700 [thread overview]
Message-ID: <20180718034600.lw6qet25kkpqquam@localhost> (raw)
In-Reply-To: <20180718011733.GA27872@embeddedor.com>
On Tue, Jul 17, 2018 at 08:17:33PM -0500, Gustavo A. R. Silva wrote:
> It seems that a *break* is missing in order to avoid falling through
> to the default case. Otherwise, checking *chan* makes no sense.
Good catch.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2018-07-18 3:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 1:17 [PATCH] ptp: fix missing break in switch Gustavo A. R. Silva
2018-07-18 3:46 ` Richard Cochran [this message]
2018-07-18 22:26 ` David Miller
2018-07-18 22:39 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718034600.lw6qet25kkpqquam@localhost \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox