Re: [PATCH net-next] net: rename ndo_setup_tc to ndo_setup_offload

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Jul 18, 2018 at 06:30:54PM +0200, Jiri Pirko wrote:
> Wed, Jul 18, 2018 at 06:14:04PM CEST, pablo@netfilter.org wrote:
> >One of the recurring complaints is that we do not have, as a driver
> >writer, a central location from which we would be fed offloading rules
> >into a NIC. This was brought up again during Netconf'18 in Boston.
> >
> >This patch just renames ndo_setup_tc to ndo_setup_offload as a very
> >early initial work to prepare for follow up patches that discuss/propose
> >unified flow representation for the existing offload programming APIs:
> >ethtool_rxnfc, cls_flower, cls_u32 and (probably, not yet upstream)
> >conntrack.
> >
> >Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> 
> It would make sense to also rename following enum:
> enum tc_setup_type {
>         TC_SETUP_QDISC_MQPRIO,
>         TC_SETUP_CLSU32,
>         TC_SETUP_CLSFLOWER,
>         TC_SETUP_CLSMATCHALL,
>         TC_SETUP_CLSBPF,
>         TC_SETUP_BLOCK,
>         TC_SETUP_QDISC_CBS,
>         TC_SETUP_QDISC_RED,
>         TC_SETUP_QDISC_PRIO,
>         TC_SETUP_QDISC_MQ,
>         TC_SETUP_QDISC_ETF,
> };
> 
> Maybe "enum setup_offload_type" and "SETUP_OFFLOAD_TC_*"?
> 
> Could you please do it in a follow-up?

Yes sure, I will do asap. Thanks Jiri.