From: David Miller <davem@davemloft.net>
To: claudiu.beznea@microchip.com
Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org,
jennifer.dahm@ni.com, nathan.sullivan@ni.com
Subject: Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs computation
Date: Thu, 19 Jul 2018 02:54:23 +0900 (KST) [thread overview]
Message-ID: <20180719.025423.1409264262161292298.davem@davemloft.net> (raw)
In-Reply-To: <1531918689-22658-4-git-send-email-claudiu.beznea@microchip.com>
From: Claudiu Beznea <claudiu.beznea@microchip.com>
Date: Wed, 18 Jul 2018 15:58:09 +0300
>
> +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
> +{
> + struct sk_buff *nskb;
> + int padlen = ETH_ZLEN - (*skb)->len;
> + int headroom = skb_headroom(*skb);
> + int tailroom = skb_tailroom(*skb);
> + bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb);
> + u32 fcs;
Please keep local variable ordered from longest to shortest line
(ie. reverse christmas tree format).
Thank you.
next prev parent reply other threads:[~2018-07-18 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 12:58 [RFC PATCH 0/3] net: macb: add pad and fcs support Claudiu Beznea
2018-07-18 12:58 ` [RFC PATCH 1/3] net: macb: use netdev_tx_t return type for ndo_start_xmit functions Claudiu Beznea
2018-07-18 12:58 ` [RFC PATCH 2/3] net: macb: move checksum clearing outside of spinlock Claudiu Beznea
2018-07-18 12:58 ` [RFC PATCH 3/3] net: macb: add support for padding and fcs computation Claudiu Beznea
2018-07-18 17:54 ` David Miller [this message]
2018-07-19 7:03 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719.025423.1409264262161292298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.beznea@microchip.com \
--cc=jennifer.dahm@ni.com \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox