From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: kafai@fb.com, yuehaibing@huawei.com, ast@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument types
Date: Sat, 21 Jul 2018 16:21:51 -0700 (PDT) [thread overview]
Message-ID: <20180721.162151.2056706808480433302.davem@davemloft.net> (raw)
In-Reply-To: <9c9f981b-7d1e-1bb2-6771-727fc762c7c5@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu, 19 Jul 2018 17:51:41 +0200
> On 07/19/2018 05:48 PM, Martin KaFai Lau wrote:
>> On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote:
>>> Fix following warning:
>>> net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type
>>> net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> LGTM. Missing a Fixes tag though.
>>
>> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
>> Acked-by: Martin KaFai Lau <kafai@fb.com>
>
> (Should go to -net tree.)
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Applied.
prev parent reply other threads:[~2018-07-21 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 7:56 [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument types YueHaibing
2018-07-19 15:48 ` Martin KaFai Lau
2018-07-19 15:51 ` Daniel Borkmann
2018-07-21 23:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721.162151.2056706808480433302.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox