From: David Miller <davem@davemloft.net>
To: lorenzo.bianconi@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv4: remove BUG_ON() from fib_compute_spec_dst
Date: Sat, 28 Jul 2018 19:07:02 -0700 (PDT) [thread overview]
Message-ID: <20180728.190702.1921184748389867883.davem@davemloft.net> (raw)
In-Reply-To: <ecd53925d2d5d5ed19c5e18b8a7998b63be39be0.1532705461.git.lorenzo.bianconi@redhat.com>
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date: Fri, 27 Jul 2018 18:15:46 +0200
> Remove BUG_ON() from fib_compute_spec_dst routine and check
> in_dev pointer during flowi4 data structure initialization.
> fib_compute_spec_dst routine can be run concurrently with device removal
> where ip_ptr net_device pointer is set to NULL. This can happen
> if userspace enables pkt info on UDP rx socket and the device
> is removed while traffic is flowing
>
> Fixes: 35ebf65e851c ("ipv4: Create and use fib_compute_spec_dst() helper")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2018-07-29 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1532705461.git.lorenzo.bianconi@redhat.com>
2018-07-27 16:15 ` [PATCH net] ipv4: remove BUG_ON() from fib_compute_spec_dst Lorenzo Bianconi
2018-07-29 2:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728.190702.1921184748389867883.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox