From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ethtool: Remove trailing semicolon for static inline
Date: Sat, 04 Aug 2018 14:56:49 -0700 (PDT) [thread overview]
Message-ID: <20180804.145649.96983648171806038.davem@davemloft.net> (raw)
In-Reply-To: <20180804212040.27562-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sat, 4 Aug 2018 14:20:40 -0700
> Android's header sanitization tool chokes on static inline functions having a
> trailing semicolon, leading to an incorrectly parsed header file. While the
> tool should obviously be fixed, also fix the header files for the two affected
> functions: ethtool_get_flow_spec_ring() and ethtool_get_flow_spec_ring_vf().
>
> Fixes: 8cf6f497de40 ("ethtool: Add helper routines to pass vf to rx_flow_spec")
> Reporetd-by: Blair Prescott <blair.prescott@broadcom.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks Florian.
Trailing semicolon removal has become so trendy all of a sudden...
prev parent reply other threads:[~2018-08-04 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 21:20 [PATCH net-next] ethtool: Remove trailing semicolon for static inline Florian Fainelli
2018-08-04 21:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804.145649.96983648171806038.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox