From: Dominique Martinet <asmadeus@codewreck.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Tomas Bortoli <tomasbortoli@gmail.com>,
David Miller <davem@davemloft.net>,
v9fs-developer@lists.sourceforge.net,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: [PATCH] 9p: fix NULL pointer dereferences
Date: Thu, 9 Aug 2018 00:41:11 +0200 [thread overview]
Message-ID: <20180808224111.GB12890@nautica> (raw)
In-Reply-To: <CACT4Y+Z+Q__-cMaQ-85H38Rs5AeFGitXoE8-Bv4pNsvat+G+xQ@mail.gmail.com>
Dmitry Vyukov wrote on Wed, Aug 08, 2018:
> > If you want to factor it in, v9fs_mount does not know which transport is
> > used, but p9_client_create does know - although the functions/structs
> > are all static so you need to check clnt->trans_mod->name with strcmp
> > and I'm honestly not sure that's better than checking in each function..
> >
> > But, as usual I'm happy as long as it works, so pick your poison :)
>
> So let's proceed with checking in each transport function?
Yes, he's done it a while ago, just didn't se the in-reply-to field to
keep part of the thread but the Reported-by was here:
http://lkml.kernel.org/r/20180727110558.5479-1-tomasbortoli@gmail.com
This is in linux-next right now as 631263a1b23c71
--
Dominique
next prev parent reply other threads:[~2018-08-08 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 8:10 [PATCH] 9p: fix NULL pointer dereferences Tomas Bortoli
2018-07-26 8:17 ` Dominique Martinet
2018-07-26 9:27 ` Dmitry Vyukov
2018-07-26 9:48 ` Dominique Martinet
2018-07-26 9:54 ` Dmitry Vyukov
2018-07-26 10:25 ` Dominique Martinet
2018-07-26 14:13 ` Tomas Bortoli
2018-07-26 14:21 ` Dominique Martinet
2018-07-26 14:32 ` Tomas Bortoli
2018-07-26 22:15 ` Dominique Martinet
2018-08-08 15:51 ` Dmitry Vyukov
2018-08-08 22:41 ` Dominique Martinet [this message]
2018-07-26 14:48 ` [V9fs-developer] " sqweek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808224111.GB12890@nautica \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=tomasbortoli@gmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox