Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ycheng@google.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
	ncardwell@google.com, brakmo@fb.com, weiwan@google.com
Subject: Re: [PATCH net-next 0/4] new mechanism to ACK immediately
Date: Sat, 11 Aug 2018 11:41:53 -0700 (PDT)	[thread overview]
Message-ID: <20180811.114153.663666446120670168.davem@davemloft.net> (raw)
In-Reply-To: <20180809163812.58365-1-ycheng@google.com>

From: Yuchung Cheng <ycheng@google.com>
Date: Thu,  9 Aug 2018 09:38:08 -0700

> This patch is a follow-up feature improvement to the recent fixes on
> the performance issues in ECN (delayed) ACKs. Many of the fixes use
> tcp_enter_quickack_mode routine to force immediate ACKs. However the
> routine also reset tracking interactive session. This is not ideal
> because these immediate ACKs are required by protocol specifics
> unrelated to the interactiveness nature of the application.
> 
> This patch set introduces a new flag to send a one-time immediate ACK
> without changing the status of interactive session tracking. With this
> patch set the immediate ACKs are generated upon these protocol states:
> 
> 1) When a hole is repaired
> 2) When CE status changes between subsequent data packets received
> 3) When a data packet carries CWR flag

This looks really nice, series applied.

Thanks!

      parent reply	other threads:[~2018-08-11 22:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 16:38 [PATCH net-next 0/4] new mechanism to ACK immediately Yuchung Cheng
2018-08-09 16:38 ` [PATCH net-next 1/4] tcp: mandate a one-time immediate ACK Yuchung Cheng
2018-08-09 16:38 ` [PATCH net-next 2/4] tcp: avoid resetting ACK timer in DCTCP Yuchung Cheng
2018-08-09 16:38 ` [PATCH net-next 3/4] tcp: always ACK immediately on hole repairs Yuchung Cheng
2018-08-09 16:38 ` [PATCH net-next 4/4] tcp: avoid resetting ACK timer upon receiving packet with ECN CWR flag Yuchung Cheng
2018-08-11 18:41 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180811.114153.663666446120670168.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brakmo@fb.com \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=weiwan@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox