From: David Miller <davem@davemloft.net>
To: salil.mehta@huawei.com
Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com,
mehta.salil.lnk@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
linyunsheng@huawei.com
Subject: Re: [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest
Date: Mon, 13 Aug 2018 08:54:56 -0700 (PDT) [thread overview]
Message-ID: <20180813.085456.1905254242911513146.davem@davemloft.net> (raw)
In-Reply-To: <20180812094738.14852-2-salil.mehta@huawei.com>
From: Salil Mehta <salil.mehta@huawei.com>
Date: Sun, 12 Aug 2018 10:47:30 +0100
> -#define HNS3_SELF_TEST_TPYE_NUM 1
> +#define HNS3_SELF_TEST_TPYE_NUM 2
Is this supposed to be the number of self test "types"? If so, this CPP
macro should be named "HNS3_SELF_TEST_TYPE_NUM".
> +
> + count ++;
^
Please remove that unnecessary space.
> + } while (++i < HCLGE_SERDES_RETRY_NUM &&
^^
Only need one space there, not two.
next prev parent reply other threads:[~2018-08-13 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 9:47 [PATCH net-next 0/9] Misc bug fixes & small enhancements for HNS3 Driver Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest Salil Mehta
2018-08-13 15:54 ` David Miller [this message]
2018-08-14 16:17 ` Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 2/9] net: hns3: Fix for command format parsing error in hclge_is_all_function_id_zero Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 3/9] net: hns3: Fix for information of phydev lost problem when down/up Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 4/9] net: hns3: Fix for phy link issue when using marvell phy driver Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 5/9] net: hns3: Fix for vf vlan delete failed problem Salil Mehta
2018-08-13 15:56 ` David Miller
2018-08-14 16:35 ` Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 6/9] net: hns3: Fix desc num set to default when setting channel Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 7/9] net: hns3: Remove tx ring BD len register in hns3_enet Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 8/9] net: hns3: Set tx ring' tc info when netdev is up Salil Mehta
2018-08-12 9:47 ` [PATCH net-next 9/9] net: hns3: Add vlan filter setting by ethtool command -K Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813.085456.1905254242911513146.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox