* [PATCH net-next] liquidio: remove set but not used variable 'is25G' @ 2018-08-13 7:21 YueHaibing 2018-08-13 9:08 ` Shaikh, Shahed 0 siblings, 1 reply; 3+ messages in thread From: YueHaibing @ 2018-08-13 7:21 UTC (permalink / raw) To: davem, derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi Cc: linux-kernel, netdev, YueHaibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function 'lio_set_link_ksettings': drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:392:6: warning: variable 'is25G' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c index 807ea2c..5ce604a 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c @@ -389,16 +389,13 @@ static int lio_set_link_ksettings(struct net_device *netdev, struct lio *lio = GET_LIO(netdev); struct oct_link_info *linfo; struct octeon_device *oct; - u32 is25G = 0; oct = lio->oct_dev; linfo = &lio->linfo; - if (oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID || - oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID) { - is25G = 1; - } else { + if (!(oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID || + oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID)) { return -EOPNOTSUPP; } -- 2.7.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] liquidio: remove set but not used variable 'is25G' 2018-08-13 7:21 [PATCH net-next] liquidio: remove set but not used variable 'is25G' YueHaibing @ 2018-08-13 9:08 ` Shaikh, Shahed 2018-08-13 9:24 ` YueHaibing 0 siblings, 1 reply; 3+ messages in thread From: Shaikh, Shahed @ 2018-08-13 9:08 UTC (permalink / raw) To: YueHaibing, davem@davemloft.net, Chickles, Derek, Burla, Satananda, Manlunas, Felix, Vatsavayi, Raghu Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org > -----Original Message----- > From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On > Behalf Of YueHaibing > Sent: Monday, August 13, 2018 12:51 PM > To: davem@davemloft.net; Chickles, Derek <Derek.Chickles@cavium.com>; > Burla, Satananda <Satananda.Burla@cavium.com>; Manlunas, Felix > <Felix.Manlunas@cavium.com>; Vatsavayi, Raghu > <Raghu.Vatsavayi@cavium.com> > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; YueHaibing > <yuehaibing@huawei.com> > Subject: [PATCH net-next] liquidio: remove set but not used variable 'is25G' > > External Email > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function > 'lio_set_link_ksettings': > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:392:6: warning: > variable 'is25G' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > index 807ea2c..5ce604a 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > @@ -389,16 +389,13 @@ static int lio_set_link_ksettings(struct net_device > *netdev, > struct lio *lio = GET_LIO(netdev); > struct oct_link_info *linfo; > struct octeon_device *oct; > - u32 is25G = 0; > > oct = lio->oct_dev; > > linfo = &lio->linfo; > > - if (oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID || > - oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID) { > - is25G = 1; > - } else { > + if (!(oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID || > + oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID)) { > return -EOPNOTSUPP; > } You can also remove braces which are not required for single line. Thanks, Shahed ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] liquidio: remove set but not used variable 'is25G' 2018-08-13 9:08 ` Shaikh, Shahed @ 2018-08-13 9:24 ` YueHaibing 0 siblings, 0 replies; 3+ messages in thread From: YueHaibing @ 2018-08-13 9:24 UTC (permalink / raw) To: Shaikh, Shahed, davem@davemloft.net, Chickles, Derek, Burla, Satananda, Manlunas, Felix, Vatsavayi, Raghu Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org On 2018/8/13 17:08, Shaikh, Shahed wrote: >> -----Original Message----- >> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On >> Behalf Of YueHaibing >> Sent: Monday, August 13, 2018 12:51 PM >> To: davem@davemloft.net; Chickles, Derek <Derek.Chickles@cavium.com>; >> Burla, Satananda <Satananda.Burla@cavium.com>; Manlunas, Felix >> <Felix.Manlunas@cavium.com>; Vatsavayi, Raghu >> <Raghu.Vatsavayi@cavium.com> >> Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; YueHaibing >> <yuehaibing@huawei.com> >> Subject: [PATCH net-next] liquidio: remove set but not used variable 'is25G' >> >> External Email >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function >> 'lio_set_link_ksettings': >> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:392:6: warning: >> variable 'is25G' set but not used [-Wunused-but-set-variable] >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c >> b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c >> index 807ea2c..5ce604a 100644 >> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c >> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c >> @@ -389,16 +389,13 @@ static int lio_set_link_ksettings(struct net_device >> *netdev, >> struct lio *lio = GET_LIO(netdev); >> struct oct_link_info *linfo; >> struct octeon_device *oct; >> - u32 is25G = 0; >> >> oct = lio->oct_dev; >> >> linfo = &lio->linfo; >> >> - if (oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID || >> - oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID) { >> - is25G = 1; >> - } else { >> + if (!(oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID || >> + oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID)) { >> return -EOPNOTSUPP; >> } > > You can also remove braces which are not required for single line. Yes, thanks. Will post v2 > Thanks, > Shahed > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-13 11:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-08-13 7:21 [PATCH net-next] liquidio: remove set but not used variable 'is25G' YueHaibing 2018-08-13 9:08 ` Shaikh, Shahed 2018-08-13 9:24 ` YueHaibing
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox