From: David Miller <davem@davemloft.net>
To: jianjian.wang1@gmail.com
Cc: jasowang@redhat.com, mst@redhat.com, willemb@google.com,
viro@zeniv.linux.org.uk, wexu@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] tap: RCU usage and comment fixes
Date: Sun, 19 Aug 2018 11:08:23 -0700 (PDT) [thread overview]
Message-ID: <20180819.110823.2099088108268644586.davem@davemloft.net> (raw)
In-Reply-To: <20180817082253.2539-1-jianjian.wang1@gmail.com>
From: Wang Jian <jianjian.wang1@gmail.com>
Date: Fri, 17 Aug 2018 08:22:53 +0000
> The tap_queue and the 'tap_dev' are loosely coupled, not 'macvlan_dev'.
There is another reference to macvlan_dev in that comment, which is therefore
also similarly inaccurate. You should add an appropriate Fixes: line for
where this inaccuracy was introduced, which is:
Fixes: 6fe3faf86757 ("tap: Abstract type of virtual interface from tap implementation")
> Taking rcu_read_lock a little later seems can slightly reduce rcu read critical section.
This is a separate change from fixing up a comment.
prev parent reply other threads:[~2018-08-19 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 8:22 [PATCH 1/1] tap: RCU usage and comment fixes Wang Jian
2018-08-19 18:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819.110823.2099088108268644586.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jianjian.wang1@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wexu@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox