Netdev List
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Sebastian Basierski <sebastianx.basierski@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 02/13] ixgbevf: VF2VF TCP RSS
Date: Tue, 28 Aug 2018 14:35:46 -0700	[thread overview]
Message-ID: <20180828213558.19273-3-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180828213558.19273-1-jeffrey.t.kirsher@intel.com>

From: Sebastian Basierski <sebastianx.basierski@intel.com>

While VF2VF with RSS communication, RSS Type were wrongly recognized
and RSS hash was not calculated as it should be. Packets was
distributed on various queues by accident.
This commit fixes that behaviour and causes proper RSS Type recognition.

Signed-off-by: Sebastian Basierski <sebastianx.basierski@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index d86446d202d5..15deac07fd92 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -3849,6 +3849,10 @@ static void ixgbevf_tx_csum(struct ixgbevf_ring *tx_ring,
 		skb_checksum_help(skb);
 		goto no_csum;
 	}
+
+	if (first->protocol == htons(ETH_P_IP))
+		type_tucmd |= IXGBE_ADVTXD_TUCMD_IPV4;
+
 	/* update TX checksum flag */
 	first->tx_flags |= IXGBE_TX_FLAGS_CSUM;
 	vlan_macip_lens = skb_checksum_start_offset(skb) -
-- 
2.17.1

  parent reply	other threads:[~2018-08-29  1:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 21:35 [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-08-28 Jeff Kirsher
2018-08-28 21:35 ` [net-next 01/13] ixgbe: firmware recovery mode Jeff Kirsher
2018-08-28 21:35 ` Jeff Kirsher [this message]
2018-08-28 21:35 ` [net-next 03/13] ixgbe: don't clear IPsec sa counters on HW clearing Jeff Kirsher
2018-08-28 21:35 ` Jeff Kirsher
2018-08-28 21:35 ` [net-next 04/13] ixgbe: reload IPsec IP table after sa tables Jeff Kirsher
2018-08-28 21:35 ` [net-next 05/13] ixgbe: prep IPsec constants for later use Jeff Kirsher
2018-08-28 21:35 ` [net-next 06/13] ixgbe: add VF IPsec management Jeff Kirsher
2018-08-28 21:35 ` [net-next 07/13] ixgbe: add VF IPsec offload enable flag Jeff Kirsher
2018-08-28 21:35 ` [net-next 08/13] ixgbe: add VF IPsec offload request message handling Jeff Kirsher
2018-08-28 21:35 ` [net-next 09/13] ixgbevf: add defines for IPsec offload request Jeff Kirsher
2018-08-28 21:35 ` [net-next 10/13] ixgbevf: add VF IPsec offload code Jeff Kirsher
2018-08-28 21:35 ` [net-next 11/13] ixgbevf: enable VF IPsec offload operations Jeff Kirsher
2018-08-28 21:35 ` [net-next 12/13] ixgbe: disallow IPsec Tx offload when in SR-IOV mode Jeff Kirsher
2018-08-28 21:35 ` [net-next 13/13] ixgbe: fix the return value for unsupported VF offload Jeff Kirsher
2018-08-29  0:01 ` [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-08-28 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828213558.19273-3-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    --cc=sebastianx.basierski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox