Netdev List
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Shannon Nelson <shannon.nelson@oracle.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 04/13] ixgbe: reload IPsec IP table after sa tables
Date: Tue, 28 Aug 2018 14:35:49 -0700	[thread overview]
Message-ID: <20180828213558.19273-6-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180828213558.19273-1-jeffrey.t.kirsher@intel.com>

From: Shannon Nelson <shannon.nelson@oracle.com>

Restore the IPsec hardware IP table after reloading the SA tables.
This doesn't make much difference now, but will matter when we add
support for VF IPsec offloads.

Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
index e515246d0bce..434065109b8d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
@@ -301,14 +301,6 @@ void ixgbe_ipsec_restore(struct ixgbe_adapter *adapter)
 	ixgbe_ipsec_clear_hw_tables(adapter);
 	ixgbe_ipsec_start_engine(adapter);
 
-	/* reload the IP addrs */
-	for (i = 0; i < IXGBE_IPSEC_MAX_RX_IP_COUNT; i++) {
-		struct rx_ip_sa *ipsa = &ipsec->ip_tbl[i];
-
-		if (ipsa->used)
-			ixgbe_ipsec_set_rx_ip(hw, i, ipsa->ipaddr);
-	}
-
 	/* reload the Rx and Tx keys */
 	for (i = 0; i < IXGBE_IPSEC_MAX_SA_COUNT; i++) {
 		struct rx_sa *rsa = &ipsec->rx_tbl[i];
@@ -322,6 +314,14 @@ void ixgbe_ipsec_restore(struct ixgbe_adapter *adapter)
 		if (tsa->used)
 			ixgbe_ipsec_set_tx_sa(hw, i, tsa->key, tsa->salt);
 	}
+
+	/* reload the IP addrs */
+	for (i = 0; i < IXGBE_IPSEC_MAX_RX_IP_COUNT; i++) {
+		struct rx_ip_sa *ipsa = &ipsec->ip_tbl[i];
+
+		if (ipsa->used)
+			ixgbe_ipsec_set_rx_ip(hw, i, ipsa->ipaddr);
+	}
 }
 
 /**
-- 
2.17.1

  parent reply	other threads:[~2018-08-29  1:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 21:35 [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-08-28 Jeff Kirsher
2018-08-28 21:35 ` [net-next 01/13] ixgbe: firmware recovery mode Jeff Kirsher
2018-08-28 21:35 ` [net-next 02/13] ixgbevf: VF2VF TCP RSS Jeff Kirsher
2018-08-28 21:35 ` [net-next 03/13] ixgbe: don't clear IPsec sa counters on HW clearing Jeff Kirsher
2018-08-28 21:35 ` Jeff Kirsher
2018-08-28 21:35 ` Jeff Kirsher [this message]
2018-08-28 21:35 ` [net-next 05/13] ixgbe: prep IPsec constants for later use Jeff Kirsher
2018-08-28 21:35 ` [net-next 06/13] ixgbe: add VF IPsec management Jeff Kirsher
2018-08-28 21:35 ` [net-next 07/13] ixgbe: add VF IPsec offload enable flag Jeff Kirsher
2018-08-28 21:35 ` [net-next 08/13] ixgbe: add VF IPsec offload request message handling Jeff Kirsher
2018-08-28 21:35 ` [net-next 09/13] ixgbevf: add defines for IPsec offload request Jeff Kirsher
2018-08-28 21:35 ` [net-next 10/13] ixgbevf: add VF IPsec offload code Jeff Kirsher
2018-08-28 21:35 ` [net-next 11/13] ixgbevf: enable VF IPsec offload operations Jeff Kirsher
2018-08-28 21:35 ` [net-next 12/13] ixgbe: disallow IPsec Tx offload when in SR-IOV mode Jeff Kirsher
2018-08-28 21:35 ` [net-next 13/13] ixgbe: fix the return value for unsupported VF offload Jeff Kirsher
2018-08-29  0:01 ` [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-08-28 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828213558.19273-6-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    --cc=shannon.nelson@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox