From: Dominique Martinet <asmadeus@codewreck.org>
To: Tomas Bortoli <tomasbortoli@gmail.com>
Cc: ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net,
davem@davemloft.net, v9fs-developer@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller@googlegroups.com
Subject: Re: [PATCH] 9p: Rename req to rreq
Date: Tue, 4 Sep 2018 00:41:27 +0200 [thread overview]
Message-ID: <20180903224127.GB25084@nautica> (raw)
In-Reply-To: <20180903160321.2181-1-tomasbortoli@gmail.com>
Tomas Bortoli wrote on Mon, Sep 03, 2018:
> Subject: Re: [PATCH] 9p: Rename req to rreq
I feel this is a bit too vague, how about either of these?
'9p: Rename req to rreq in trans_fd'
or
'9p/fd: Rename req to rreq'
We still have plenty of 'req' in client.c and all other transports, so
it would feel like a lie otherwise :)
> In struct p9_conn, rename req to rreq as it is used by the read routine.
>
> Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
> Suggested-by: Jun Piao <piaojun@huawei.com>
Nitpick on title aside LGTM, I've picked this up for linux-next
--
Dominique
prev parent reply other threads:[~2018-09-03 22:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 16:03 [PATCH] 9p: Rename req to rreq Tomas Bortoli
2018-09-03 22:41 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903224127.GB25084@nautica \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=rminnich@sandia.gov \
--cc=syzkaller@googlegroups.com \
--cc=tomasbortoli@gmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox