From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: ap420073@gmail.com, posk@google.com, netdev@vger.kernel.org,
pablo@netfilter.org, fw@strlen.de
Subject: Re: [PATCH net V2] ip: frags: fix crash in ip_do_fragment()
Date: Sun, 09 Sep 2018 14:51:33 -0700 (PDT) [thread overview]
Message-ID: <20180909.145133.589038459266292694.davem@davemloft.net> (raw)
In-Reply-To: <CANn89iKXTr+zy7ms5v7RNaz0BvQ1DMt+A7OfyPkypJZ9BvzeDg@mail.gmail.com>
From: Eric Dumazet <edumazet@google.com>
Date: Sun, 9 Sep 2018 13:51:21 -0700
>> Hi Eric,
>> Thank you for review!
>>
>> I think netfilter side ipv6 code change is needed
>> because netfilter ipv6 defrag routine also set fp->ip_defrag_offset value
>> so that fp->sk will not be NULL.
>> And I think these crash in ip_do_fragment() and ip6_fragment() are
>> actually same bug.
>>
>
> Right you are, thanks.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Applied, thanks everyone.
prev parent reply other threads:[~2018-09-10 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-09 17:47 [PATCH net V2] ip: frags: fix crash in ip_do_fragment() Taehee Yoo
2018-09-09 18:24 ` Eric Dumazet
2018-09-09 18:54 ` Taehee Yoo
2018-09-09 20:51 ` Eric Dumazet
2018-09-09 21:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180909.145133.589038459266292694.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ap420073@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=posk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox