From: Tobias Hommel <netdev-list@genoetigt.de>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Wolfgang Walter <linux@stwm.de>,
netdev@vger.kernel.org, Wei Wang <weiwan@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: kernels > v4.12 oops/crash with ipsec-traffic: bisected to b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the operation of dst_free()
Date: Mon, 10 Sep 2018 11:06:22 +0200 [thread overview]
Message-ID: <20180910090622.avunyp4agk4ueara@arbeitstier> (raw)
In-Reply-To: <20180910063739.GX23674@gauss3.secunet.de>
On Mon, Sep 10, 2018 at 08:37:39AM +0200, Steffen Klassert wrote:
...
> The other thing I wonder about is why Tobias bisected this to
>
> commit b838d5e1c5b6e57b10ec8af2268824041e3ea911
> ipv4: mark DST_NOGC and remove the operation of dst_free()
>
> from 'Jun 17 2017' and not to
>
> commit 222d7dbd258dad4cd5241c43ef818141fad5a87a
> net: prevent dst uses after free
>
> from 'Sep 21 2017'.
>
> Maybe Tobias has seen two bugs. Before
> ("net: prevent dst uses after free"), it was the
> use after free, and after this fix it was a NULL
> pointer derference of skb->dst.
>
Uhm, yeah, I checked back, we actually had different bugs. My mistake, sorry
for the confusion.
prev parent reply other threads:[~2018-09-10 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 10:48 kernels >= v4.12 oops/crash with ipsec-traffic: partly bisected Wolfgang Walter
2018-08-30 18:53 ` kernels > v4.12 oops/crash with ipsec-traffic: bisected to b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the operation of dst_free() Wolfgang Walter
2018-08-31 6:50 ` Steffen Klassert
2018-09-07 9:53 ` Wolfgang Walter
2018-09-07 20:22 ` Wolfgang Walter
2018-09-07 21:10 ` Wolfgang Walter
2018-09-10 6:37 ` Steffen Klassert
2018-09-10 8:18 ` Kristian Evensen
2018-09-10 10:46 ` Wolfgang Walter
2018-09-11 10:33 ` Steffen Klassert
2018-09-11 16:53 ` Wolfgang Walter
2018-09-11 19:02 ` Tobias Hommel
2018-09-12 8:50 ` Steffen Klassert
2018-09-12 15:18 ` Tobias Hommel
2018-09-19 18:38 ` Tobias Hommel
2018-09-10 9:06 ` Tobias Hommel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910090622.avunyp4agk4ueara@arbeitstier \
--to=netdev-list@genoetigt.de \
--cc=edumazet@google.com \
--cc=linux@stwm.de \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox