From: Jiri Pirko <jiri@resnulli.us>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: davem@davemloft.net, michael.chan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload
Date: Tue, 11 Sep 2018 11:51:30 +0200 [thread overview]
Message-ID: <20180911095130.GC25110@nanopsycho> (raw)
In-Reply-To: <1536655505-14387-2-git-send-email-vasundhara-v.volam@broadcom.com>
Tue, Sep 11, 2018 at 10:44:58AM CEST, vasundhara-v.volam@broadcom.com wrote:
>hw_tc_offload - Enable/Disable TC flower offload in the device.
>
>Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
>---
> include/net/devlink.h | 4 ++++
> net/core/devlink.c | 5 +++++
> 2 files changed, 9 insertions(+)
>
>diff --git a/include/net/devlink.h b/include/net/devlink.h
>index b9b89d6..a0e9ce9 100644
>--- a/include/net/devlink.h
>+++ b/include/net/devlink.h
>@@ -362,6 +362,7 @@ enum devlink_param_generic_id {
> DEVLINK_PARAM_GENERIC_ID_MAX_MACS,
> DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV,
> DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT,
>+ DEVLINK_PARAM_GENERIC_ID_HW_TC_OFFLOAD,
Could you please describe why do you need this here and why the
tc_offload flag in ethtool is not enough. How do you imagine the user
should use them together?
next prev parent reply other threads:[~2018-09-11 14:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 8:44 [PATCH net-next 0/8] bnxt_en: devlink param updates Vasundhara Volam
2018-09-11 8:44 ` [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload Vasundhara Volam
2018-09-11 9:51 ` Jiri Pirko [this message]
2018-09-12 6:17 ` Vasundhara Volam
2018-09-12 6:34 ` Jakub Kicinski
2018-09-13 9:08 ` Jiri Pirko
2018-09-11 8:44 ` [PATCH net-next 2/8] devlink: Add generic parameter ignore_ari Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 3/8] devlink: Add generic parameter msix_vec_per_pf_max Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 4/8] devlink: Add generic parameter msix_vec_per_pf_min Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 5/8] bnxt_en: Use hw_tc_offload and ignore_ari devlink parameters Vasundhara Volam
2018-09-14 8:58 ` kbuild test robot
2018-09-11 8:45 ` [PATCH net-next 6/8] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 7/8] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params Vasundhara Volam
2018-09-11 8:45 ` [PATCH net-next 8/8] bnxt_en: Add a driver specific devlink parameter Vasundhara Volam
2018-09-11 11:33 ` [PATCH net-next 0/8] bnxt_en: devlink param updates Jakub Kicinski
2018-09-11 11:51 ` Jiri Pirko
2018-09-12 6:40 ` Vasundhara Volam
2018-09-12 6:39 ` Vasundhara Volam
2018-09-12 9:50 ` Jakub Kicinski
2018-09-14 4:17 ` Vasundhara Volam
2018-09-14 10:01 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911095130.GC25110@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox