From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
liam.mcbirnie@boeing.com
Subject: Re: [PATCH net] net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags
Date: Thu, 13 Sep 2018 11:02:53 -0700 (PDT) [thread overview]
Message-ID: <20180913.110253.1107152404318857888.davem@davemloft.net> (raw)
In-Reply-To: <1536783708-21949-1-git-send-email-roopa@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Wed, 12 Sep 2018 13:21:48 -0700
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071
>
> Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of
> dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED.
> Fix it by indicating flag changes explicitly to __dev_notify_flags.
>
> Fixes: 5025f7f7d506 ("rtnetlink: add rtnl_link_state check in rtnl_configure_link")
> Reported-By: Liam mcbirnie <liam.mcbirnie@boeing.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied.
> ---
> Dave, if 5025f7f7d506 made it to stable, request you to pls queue this one up too. Thanks.
I will, thanks.
prev parent reply other threads:[~2018-09-13 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 20:21 [PATCH net] net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags Roopa Prabhu
2018-09-13 18:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913.110253.1107152404318857888.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=liam.mcbirnie@boeing.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox