From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Mauricio Vasquez B <mauricio.vasquez@polito.it>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Yonghong Song <yhs@fb.com>
Subject: Re: [RFC PATCH bpf-next v3 1/7] bpf: rename stack trace map
Date: Tue, 18 Sep 2018 16:05:52 -0700 [thread overview]
Message-ID: <20180918230551.7rh3wytacry7i3wl@ast-mbp> (raw)
In-Reply-To: <153724635419.7866.6301500459081173494.stgit@kernel>
On Tue, Sep 18, 2018 at 06:52:34AM +0200, Mauricio Vasquez B wrote:
> In the following patches queue and stack maps (FIFO and LIFO
> datastructures) will be implemented. In order to avoid confusion and
> a possible name clash rename stackmap.c to stacktracemap.c and
> stack_map_ops to stack_trace_map_ops
>
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
> ---
> include/linux/bpf_types.h | 2
> kernel/bpf/Makefile | 2
> kernel/bpf/stackmap.c | 624 --------------------------------------------
> kernel/bpf/stacktracemap.c | 624 ++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 626 insertions(+), 626 deletions(-)
> delete mode 100644 kernel/bpf/stackmap.c
> create mode 100644 kernel/bpf/stacktracemap.c
Just new file for stack/queue will be enough. I understand that unfortunate name confusion,
but this is too late. It will cause all sorts of headaches in fixes that go to net/stable.
next prev parent reply other threads:[~2018-09-19 4:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 4:52 [RFC PATCH bpf-next v3 0/7] Implement bpf queue/stack maps Mauricio Vasquez B
2018-09-18 4:52 ` [RFC PATCH bpf-next v3 1/7] bpf: rename stack trace map Mauricio Vasquez B
2018-09-18 23:05 ` Alexei Starovoitov [this message]
2018-09-19 2:53 ` Mauricio Vasquez
2018-09-18 4:52 ` [RFC PATCH bpf-next v3 2/7] bpf/syscall: allow key to be null in map functions Mauricio Vasquez B
2018-09-18 4:52 ` [RFC PATCH bpf-next v3 3/7] bpf: add lookup_and_delete map operation Mauricio Vasquez B
2018-09-18 4:52 ` [RFC PATCH bpf-next v3 4/7] bpf: add bpf queue and stack maps Mauricio Vasquez B
2018-09-18 23:27 ` Alexei Starovoitov
2018-09-19 4:28 ` Mauricio Vasquez
[not found] ` <12a0d7d2-9590-b44f-803a-a00eefe611c1@polito.it>
2018-10-02 0:26 ` Alexei Starovoitov
2018-10-03 17:01 ` Mauricio Vasquez
2018-10-03 21:10 ` Alexei Starovoitov
2018-09-18 4:52 ` [RFC PATCH bpf-next v3 5/7] bpf: restrict use of peek/push/pop Mauricio Vasquez B
2018-09-18 4:53 ` [RFC PATCH bpf-next v3 6/7] Sync uapi/bpf.h to tools/include Mauricio Vasquez B
2018-09-18 4:53 ` [RFC PATCH bpf-next v3 7/7] selftests/bpf: add test cases for queue and stack maps Mauricio Vasquez B
2018-09-18 23:32 ` Alexei Starovoitov
2018-09-19 4:36 ` Mauricio Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918230551.7rh3wytacry7i3wl@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=mauricio.vasquez@polito.it \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox