* [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev
@ 2018-09-21 17:58 Eric Dumazet
2018-09-21 18:01 ` Eric Dumazet
2018-09-21 18:03 ` David Ahern
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-09-21 17:58 UTC (permalink / raw)
To: David S . Miller; +Cc: netdev, Eric Dumazet, Eric Dumazet, David Ahern
net/ipv4/fib_frontend.c: In function 'fib_info_nh_uses_dev':
net/ipv4/fib_frontend.c:322:6: error: unused variable 'ret' [-Werror=unused-variable]
cc1: all warnings being treated as errors
Fixes: 78f2756c5fc0 ("net/ipv4: Move device validation to helper")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: David Ahern <dsahern@gmail.com>
---
net/ipv4/fib_frontend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 222b968de94cbff98c4a1b4a2f298b2e68452984..30e2bcc3ef2a293568076228fecf3cf07ba01f20 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -318,9 +318,9 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb)
bool fib_info_nh_uses_dev(struct fib_info *fi, const struct net_device *dev)
{
bool dev_match = false;
+#ifdef CONFIG_IP_ROUTE_MULTIPATH
int ret;
-#ifdef CONFIG_IP_ROUTE_MULTIPATH
for (ret = 0; ret < fi->fib_nhs; ret++) {
struct fib_nh *nh = &fi->fib_nh[ret];
--
2.19.0.444.g18242da7ef-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev
2018-09-21 17:58 [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev Eric Dumazet
@ 2018-09-21 18:01 ` Eric Dumazet
2018-09-21 18:03 ` David Ahern
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-09-21 18:01 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller; +Cc: netdev, Eric Dumazet, David Ahern
On 09/21/2018 10:58 AM, Eric Dumazet wrote:
> net/ipv4/fib_frontend.c: In function 'fib_info_nh_uses_dev':
> net/ipv4/fib_frontend.c:322:6: error: unused variable 'ret' [-Werror=unused-variable]
> cc1: all warnings being treated as errors
>
> Fixes: 78f2756c5fc0 ("net/ipv4: Move device validation to helper")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: David Ahern <dsahern@gmail.com>
>
This targets net-next tree, sorry for the wrong tag in title.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev
2018-09-21 17:58 [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev Eric Dumazet
2018-09-21 18:01 ` Eric Dumazet
@ 2018-09-21 18:03 ` David Ahern
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2018-09-21 18:03 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller; +Cc: netdev, Eric Dumazet
On 9/21/18 10:58 AM, Eric Dumazet wrote:
> net/ipv4/fib_frontend.c: In function 'fib_info_nh_uses_dev':
> net/ipv4/fib_frontend.c:322:6: error: unused variable 'ret' [-Werror=unused-variable]
> cc1: all warnings being treated as errors
>
> Fixes: 78f2756c5fc0 ("net/ipv4: Move device validation to helper")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: David Ahern <dsahern@gmail.com>
> ---
> net/ipv4/fib_frontend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index 222b968de94cbff98c4a1b4a2f298b2e68452984..30e2bcc3ef2a293568076228fecf3cf07ba01f20 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -318,9 +318,9 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb)
> bool fib_info_nh_uses_dev(struct fib_info *fi, const struct net_device *dev)
> {
> bool dev_match = false;
> +#ifdef CONFIG_IP_ROUTE_MULTIPATH
> int ret;
>
> -#ifdef CONFIG_IP_ROUTE_MULTIPATH
> for (ret = 0; ret < fi->fib_nhs; ret++) {
> struct fib_nh *nh = &fi->fib_nh[ret];
>
>
Reviewed-by: David Ahern <dsahern@gmail.com>
Thanks for the fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-21 23:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 17:58 [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev Eric Dumazet
2018-09-21 18:01 ` Eric Dumazet
2018-09-21 18:03 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox