From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates
Date: Tue, 25 Sep 2018 07:06:34 -0700 [thread overview]
Message-ID: <20180925070634.05d05e83@cakuba.netronome.com> (raw)
In-Reply-To: <CAACQVJoR1LKyZmeNbRmjOL6w5iKfE2cnshRTs92r1zCXjiS_pg@mail.gmail.com>
On Tue, 25 Sep 2018 09:44:41 +0530, Vasundhara Volam wrote:
> On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
> >
> > On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:
> > > This patchset adds support for 3 generic and 1 driver-specific devlink
> > > parameters. Add documentation for these configuration parameters.
> > >
> > > Also, this patchset adds support to return proper error code if
> > > HWRM_NVM_GET/SET_VARIABLE commands return error code
> > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED.
> > >
> > > v1->v2:
> > > -Remove hw_tc_offload parameter.
> > > -Update all patches with Cc of MAINTAINERS.
> > > -Add more description in commit message for device specific parameter.
> > > -Add a new Documentation/networking/devlink-params.txt with some
> > > generic devlink parameters information.
> > > -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink
> > > parameters information that are supported by bnxt_en driver.
> > >
> > > Vasundhara Volam (9):
> > > devlink: Add generic parameter ignore_ari
> > > devlink: Add generic parameter msix_vec_per_pf_max
> > > devlink: Add generic parameter msix_vec_per_pf_min
> >
> > Nobody agreed with me that we need structure the PCIe bits better so
> > I'll let go...
> >
> > > bnxt_en: Use ignore_ari devlink parameter
> > > bnxt_en: return proper error when FW returns
> > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
> > > bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
> > > params.
> > > bnxt_en: Add a driver specific gre_ver_check devlink parameter.
> >
> > This looks like configuring forwarding rules with devlink, but again,
> Do you think, this parameter should be made generic?
By no means.
> > I won't object if I'm the only one who finds this inappropriate.
> >
> > You should CC people who gave you feedback on the previous version.
> Sorry, I will add in the next version of the patchset. Thanks.
> >
> > > devlink: Add Documentation/networking/devlink-params.txt
> > > devlink: Add Documentation/networking/devlink-params-bnxt.txt
prev parent reply other threads:[~2018-09-25 20:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 1/9] devlink: Add generic parameter ignore_ari Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt Vasundhara Volam
2018-09-24 16:24 ` Jakub Kicinski
2018-09-25 4:07 ` Vasundhara Volam
2018-09-25 14:05 ` Jakub Kicinski
2018-09-24 16:39 ` [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Jakub Kicinski
2018-09-25 4:14 ` Vasundhara Volam
2018-09-25 14:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925070634.05d05e83@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox