From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
"Björn Töpel" <bjorn.topel@intel.com>,
magnus.karlsson@intel.com, magnus.karlsson@gmail.com,
ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
brouer@redhat.com, u9012063@gmail.com, tuc@vmware.com
Subject: Re: [PATCH 3/5] ixgbe: add AF_XDP zero-copy Rx support
Date: Tue, 25 Sep 2018 07:57:14 -0700 [thread overview]
Message-ID: <20180925075714.75db73ac@cakuba.netronome.com> (raw)
In-Reply-To: <20180924163557.1187-4-bjorn.topel@gmail.com>
On Mon, 24 Sep 2018 18:35:55 +0200, Björn Töpel wrote:
> + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
> + return -EINVAL;
> +
> + if (adapter->flags & IXGBE_FLAG_DCB_ENABLED)
> + return -EINVAL;
Hm, should you add UMEM checks to all the places these may get
enabled? Like fabf1bce103a ("ixgbe: Prevent unsupported configurations
with XDP") did?
next prev parent reply other threads:[~2018-09-25 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 16:35 [PATCH 0/5] Introducing ixgbe AF_XDP ZC support Björn Töpel
2018-09-24 16:35 ` [PATCH 1/5] ixgbe: added Rx/Tx ring disable/enable functions Björn Töpel
2018-09-24 16:35 ` [PATCH 2/5] ixgbe: move common Rx functions to ixgbe_txrx_common.h Björn Töpel
2018-09-24 16:35 ` [PATCH 3/5] ixgbe: add AF_XDP zero-copy Rx support Björn Töpel
2018-09-25 14:57 ` Jakub Kicinski [this message]
2018-09-26 14:29 ` Björn Töpel
2018-09-24 16:35 ` [PATCH 4/5] ixgbe: move common Tx functions to ixgbe_txrx_common.h Björn Töpel
2018-09-24 16:35 ` [PATCH 5/5] ixgbe: add AF_XDP zero-copy Tx support Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925075714.75db73ac@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tuc@vmware.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox