From: Eric Dumazet <edumazet@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Michael Chan <michael.chan@broadcom.com>,
Aviad Krawczyk <aviad.krawczyk@huawei.com>,
Song Liu <songliubraving@fb.com>,
Douglas Miller <dougmill@linux.vnet.ibm.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Harish Patil <harish.patil@cavium.com>,
Manish Chopra <manish.chopra@cavium.com>,
Netanel Belgazal <netanel@amazon.com>,
Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
Rahul Verma <rahul.verma@cavium.com>
Subject: [PATCH net 07/11] qlogic: netxen: remove ndo_poll_controller
Date: Thu, 27 Sep 2018 09:31:57 -0700 [thread overview]
Message-ID: <20180927163201.56609-8-edumazet@google.com> (raw)
In-Reply-To: <20180927163201.56609-1-edumazet@google.com>
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
netxen uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Manish Chopra <manish.chopra@cavium.com>
Cc: Rahul Verma <rahul.verma@cavium.com>
---
.../ethernet/qlogic/netxen/netxen_nic_main.c | 23 -------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 69aa7fc392c5e4ad1cbcd9025f56bffdf3aa92c7..59c70be22a84c11262388529cf0ddf09887cea96 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -72,9 +72,6 @@ static void netxen_schedule_work(struct netxen_adapter *adapter,
work_func_t func, int delay);
static void netxen_cancel_fw_work(struct netxen_adapter *adapter);
static int netxen_nic_poll(struct napi_struct *napi, int budget);
-#ifdef CONFIG_NET_POLL_CONTROLLER
-static void netxen_nic_poll_controller(struct net_device *netdev);
-#endif
static void netxen_create_sysfs_entries(struct netxen_adapter *adapter);
static void netxen_remove_sysfs_entries(struct netxen_adapter *adapter);
@@ -581,9 +578,6 @@ static const struct net_device_ops netxen_netdev_ops = {
.ndo_tx_timeout = netxen_tx_timeout,
.ndo_fix_features = netxen_fix_features,
.ndo_set_features = netxen_set_features,
-#ifdef CONFIG_NET_POLL_CONTROLLER
- .ndo_poll_controller = netxen_nic_poll_controller,
-#endif
};
static inline bool netxen_function_zero(struct pci_dev *pdev)
@@ -2402,23 +2396,6 @@ static int netxen_nic_poll(struct napi_struct *napi, int budget)
return work_done;
}
-#ifdef CONFIG_NET_POLL_CONTROLLER
-static void netxen_nic_poll_controller(struct net_device *netdev)
-{
- int ring;
- struct nx_host_sds_ring *sds_ring;
- struct netxen_adapter *adapter = netdev_priv(netdev);
- struct netxen_recv_context *recv_ctx = &adapter->recv_ctx;
-
- disable_irq(adapter->irq);
- for (ring = 0; ring < adapter->max_sds_rings; ring++) {
- sds_ring = &recv_ctx->sds_rings[ring];
- netxen_intr(adapter->irq, sds_ring);
- }
- enable_irq(adapter->irq);
-}
-#endif
-
static int
nx_incr_dev_ref_cnt(struct netxen_adapter *adapter)
{
--
2.19.0.605.g01d371f741-goog
next prev parent reply other threads:[~2018-09-27 22:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 16:31 [PATCH net 00/11] netpoll: second round of fixes Eric Dumazet
2018-09-27 16:31 ` [PATCH net 01/11] netpoll: do not test NAPI_STATE_SCHED in poll_one_napi() Eric Dumazet
2018-09-27 18:25 ` Michael Chan
2018-09-27 18:33 ` Song Liu
2018-09-27 16:31 ` [PATCH net 02/11] hinic: remove ndo_poll_controller Eric Dumazet
2018-09-27 16:31 ` [PATCH net 03/11] ehea: " Eric Dumazet
2018-09-27 16:31 ` [PATCH net 04/11] net: hns: " Eric Dumazet
2018-09-27 16:31 ` [PATCH net 05/11] virtio_net: " Eric Dumazet
2018-09-27 16:31 ` [PATCH net 06/11] qlcnic: " Eric Dumazet
2018-09-27 16:31 ` Eric Dumazet [this message]
2018-09-27 16:31 ` [PATCH net 08/11] net: ena: " Eric Dumazet
2018-09-27 16:31 ` [PATCH net 09/11] sfc: " Eric Dumazet
2018-09-28 7:30 ` Bert Kenward
2018-09-27 16:32 ` [PATCH net 10/11] sfc-falcon: " Eric Dumazet
2018-09-28 7:30 ` Bert Kenward
2018-09-27 16:32 ` [PATCH net 11/11] ibmvnic: " Eric Dumazet
2018-09-28 18:14 ` [PATCH net 00/11] netpoll: second round of fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927163201.56609-8-edumazet@google.com \
--to=edumazet@google.com \
--cc=aviad.krawczyk@huawei.com \
--cc=davem@davemloft.net \
--cc=dougmill@linux.vnet.ibm.com \
--cc=harish.patil@cavium.com \
--cc=jasowang@redhat.com \
--cc=linux-net-drivers@solarflare.com \
--cc=manish.chopra@cavium.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.verma@cavium.com \
--cc=songliubraving@fb.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox