Bad MAINTAINERS pattern in section 'NETWORKING [IPSEC]'

Bad MAINTAINERS pattern in section 'NETWORKING [IPSEC]'

[Joe Perches]

Please fix this defect appropriately.

linux-next MAINTAINERS section:

	10233	NETWORKING [IPSEC]
	10234	M:	Steffen Klassert <steffen.klassert@secunet.com>
	10235	M:	Herbert Xu <herbert@gondor.apana.org.au>
	10236	M:	"David S. Miller" <davem@davemloft.net>
	10237	L:	netdev@vger.kernel.org
	10238	T:	git git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git
	10239	T:	git git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git
	10240	S:	Maintained
-->	10241	F:	net/core/flow.c
	10242	F:	net/xfrm/
	10243	F:	net/key/
	10244	F:	net/ipv4/xfrm*
	10245	F:	net/ipv4/esp4*
	10246	F:	net/ipv4/ah4.c
	10247	F:	net/ipv4/ipcomp.c
	10248	F:	net/ipv4/ip_vti.c
	10249	F:	net/ipv6/xfrm*
	10250	F:	net/ipv6/esp6*
	10251	F:	net/ipv6/ah6.c
	10252	F:	net/ipv6/ipcomp6.c
	10253	F:	net/ipv6/ip6_vti.c
	10254	F:	include/uapi/linux/xfrm.h
	10255	F:	include/net/xfrm.h

Commit that introduced this:

commit 5826bdd1816fa2baa122b62e14905c0ad8e7b96a
 Author: Fan Du <fan.du@windriver.com>
 Date:   Sat Jan 18 09:55:28 2014 +0800
 
     flowcache: Bring net/core/flow.c under IPsec maintain scope
     
     As flow cache is mainly manipulated from IPsec.
     
     Signed-off-by: Fan Du <fan.du@windriver.com>
     Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
 
  MAINTAINERS | 1 +
  1 file changed, 1 insertion(+)

Last commit with net/core/flow.c

commit 09c7570480f7544ffbf8e6db365208b0b0c154c6
Author: Florian Westphal <fw@strlen.de>
Date:   Mon Jul 17 13:57:26 2017 +0200

    xfrm: remove flow cache
    
    After rcu conversions performance degradation in forward tests isn't that
    noticeable anymore.
    
    See next patch for some numbers.
    
    A followup patcg could then also remove genid from the policies
    as we do not cache bundles anymore.
    
    Signed-off-by: Florian Westphal <fw@strlen.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>

 include/net/flow.h              |  34 ---
 include/net/flowcache.h         |  25 --
 include/net/netns/xfrm.h        |  11 -
 include/net/xfrm.h              |   8 -
 net/core/Makefile               |   1 -
 net/core/flow.c                 | 516 ----------------------------------------
 net/ipv4/xfrm4_policy.c         |   9 -
 net/ipv6/xfrm6_policy.c         |   9 -
 net/key/af_key.c                |   6 -
 net/xfrm/xfrm_device.c          |   2 -
 net/xfrm/xfrm_policy.c          | 108 +--------
 net/xfrm/xfrm_user.c            |   3 -
 security/selinux/include/xfrm.h |   4 +-
 13 files changed, 2 insertions(+), 734 deletions(-)

Re: Bad MAINTAINERS pattern in section 'NETWORKING [IPSEC]'

[Steffen Klassert]

On Fri, Sep 28, 2018 at 03:01:23PM -0700, Joe Perches wrote:
> Please fix this defect appropriately.
> 
> linux-next MAINTAINERS section:
> 
> 	10233	NETWORKING [IPSEC]
> 	10234	M:	Steffen Klassert <steffen.klassert@secunet.com>
> 	10235	M:	Herbert Xu <herbert@gondor.apana.org.au>
> 	10236	M:	"David S. Miller" <davem@davemloft.net>
> 	10237	L:	netdev@vger.kernel.org
> 	10238	T:	git git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git
> 	10239	T:	git git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git
> 	10240	S:	Maintained
> -->	10241	F:	net/core/flow.c

This file went away with the flowcache removal.
I plan to apply the patch below to the ipsec tree:

Subject: [PATCH] MAINTAINERS: Remove net/core/flow.c

net/core/flow.c does not exist anymore, so remove it
from the IPSEC NETWORKING section of the MAINTAINERS
file.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index dcb0191c4f54..4ff21dac9b45 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10130,7 +10130,6 @@ L:	netdev@vger.kernel.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git
 S:	Maintained
-F:	net/core/flow.c
 F:	net/xfrm/
 F:	net/key/
 F:	net/ipv4/xfrm*
-- 
2.17.1