From: David Miller <davem@davemloft.net>
To: shahed.shaikh@cavium.com
Cc: netdev@vger.kernel.org, Manish.Chopra@cavium.com,
Dept-GELinuxNICDev@cavium.com
Subject: Re: [PATCH net 1/1] qlcnic: fix Tx descriptor corruption on 82xx devices
Date: Sat, 29 Sep 2018 11:47:13 -0700 (PDT) [thread overview]
Message-ID: <20180929.114713.2223247016931278384.davem@davemloft.net> (raw)
In-Reply-To: <20180926194110.28043-1-shahed.shaikh@cavium.com>
From: Shahed Shaikh <shahed.shaikh@cavium.com>
Date: Wed, 26 Sep 2018 12:41:10 -0700
> In regular NIC transmission flow, driver always configures MAC using
> Tx queue zero descriptor as a part of MAC learning flow.
> But with multi Tx queue supported NIC, regular transmission can occur on
> any non-zero Tx queue and from that context it uses
> Tx queue zero descriptor to configure MAC, at the same time TX queue
> zero could be used by another CPU for regular transmission
> which could lead to Tx queue zero descriptor corruption and cause FW
> abort.
>
> This patch fixes this in such a way that driver always configures
> learned MAC address from the same Tx queue which is used for
> regular transmission.
>
> Fixes: 7e2cf4feba05 ("qlcnic: change driver hardware interface mechanism")
> Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2018-09-30 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 19:41 [PATCH net 1/1] qlcnic: fix Tx descriptor corruption on 82xx devices Shahed Shaikh
2018-09-29 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929.114713.2223247016931278384.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=Manish.Chopra@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=shahed.shaikh@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox