From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Chas Williams <3chas3@gmail.com>,
Jan Blunck <jblunck@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] team: set IFF_SLAVE on team ports
Date: Sun, 30 Sep 2018 11:38:05 +0200 [thread overview]
Message-ID: <20180930113805.3b8e62a1@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20180930071414.GF2209@nanopsycho.orion>
On Sun, 30 Sep 2018 09:14:14 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> Thu, Sep 27, 2018 at 04:04:26PM CEST, 3chas3@gmail.com wrote:
> >
> >
> >On 07/10/15 02:41, Jiri Pirko wrote:
> >> Thu, Jul 09, 2015 at 05:36:55PM CEST, jblunck@infradead.org wrote:
> >> > On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> >> > > Thu, Jul 09, 2015 at 11:58:34AM CEST, jblunck@infradead.org wrote:
> >> > > > The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to
> >> > > > decide if it should start the address configuration. Since team ports
> >> > > > shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking
> >> > > > a port to the team master.
> >> > >
> >> > > I don't want to use IFF_SLAVE in team. Other master-slave devices are
> >> > > not using that as well, for example bridge, ovs, etc.
> >> > >
> >> >
> >> > Maybe they need to get fixed too. I've used that flag because it is
> >> > documented as
> >> > a "slave of a load balancer" which describes what a team port is.
> >> >
> >> >
> >> > > I think that this should be fixed in addrconf_notify. It should lookup
> >> > > if there is a master on top and bail out in that case.
> >> >
> >> > There are other virtual interfaces that have a master assigned and want to
> >> > participate in IPv6 address configuration.
> >>
> >> Can you give me an example?
> >
> >I would like to revisit this patch (yes, I know it has been a while). I
> >believe the VRF implementation uses master to group the interfaces under
> >a single interface.
> >
> >I don't see a reason not to use IFF_SLAVE since team and bonding are fairly
> >similar.
>
> Again, why do you need team port to have IFF_SLAVE flag? What do you
> want to achieve
Without setting this flag IPv6 will try and make a link specific address.
next prev parent reply other threads:[~2018-09-30 16:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 9:58 [PATCH] team: set IFF_SLAVE on team ports Jan Blunck
2015-07-09 10:07 ` Jiri Pirko
2015-07-09 15:36 ` Jan Blunck
2015-07-10 6:41 ` Jiri Pirko
2018-09-27 14:04 ` Chas Williams
2018-09-30 7:14 ` Jiri Pirko
2018-09-30 9:38 ` Stephen Hemminger [this message]
2018-09-30 9:34 ` Jiri Pirko
2018-10-01 14:06 ` Chas Williams
2018-10-02 11:12 ` Jiri Pirko
2018-10-02 21:20 ` Chas Williams
2018-10-03 10:44 ` Jiri Pirko
2018-10-03 17:30 ` Chas Williams
2018-10-05 6:46 ` Jiri Pirko
2018-10-06 13:28 ` Chas Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180930113805.3b8e62a1@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=3chas3@gmail.com \
--cc=jblunck@infradead.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox