Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
	roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
	mlxsw@mellanox.com
Subject: Re: [PATCH net-next] bridge: mcast: Default back to multicast enabled state
Date: Tue, 02 Oct 2018 22:27:51 -0700 (PDT)	[thread overview]
Message-ID: <20181002.222751.1282381500734131142.davem@davemloft.net> (raw)
In-Reply-To: <20181001085701.23295-1-idosch@mellanox.com>

From: Ido Schimmel <idosch@mellanox.com>
Date: Mon,  1 Oct 2018 11:57:01 +0300

> Commit 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled")
> converted the 'multicast_disabled' field to an option bit named
> 'BROPT_MULTICAST_ENABLED'.
> 
> While the old field was implicitly initialized to 0, the new field is
> not initialized, resulting in the bridge defaulting to multicast
> disabled state and breaking existing applications.
> 
> Fix this by explicitly initializing the option.
> 
> Fixes: 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>

Applied.

      parent reply	other threads:[~2018-10-03 12:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01  8:57 [PATCH net-next] bridge: mcast: Default back to multicast enabled state Ido Schimmel
2018-10-01  9:07 ` Nikolay Aleksandrov
2018-10-03  5:27 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002.222751.1282381500734131142.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=idosch@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox